Re: [PATCH 5.4.y] openvswitch: Fix unsafe attribute parsing in output_userspace()

[Eelco Chaudron <echaudro@redhat.com>]

On 12 May 2025, at 23:52, Sasha Levin wrote:

> [ Sasha's backport helper bot ]
>
> Hi,
>
> Summary of potential issues:
> ⚠️ Found matching upstream commit but patch is missing proper reference to it
>
> Found matching upstream commit: 6beb6835c1fbb3f676aebb51a5fee6b77fed9308
>
> Status in newer kernel trees:
> 6.14.y | Present (different SHA1: 4d184c1b89b8)
> 6.12.y | Present (different SHA1: 4ae0a4524c47)
> 6.6.y | Present (different SHA1: 46e070d3714b)
> 6.1.y | Present (different SHA1: 68544f9fe709)
> 5.15.y | Present (different SHA1: 99deb2bf2bd1)
> 5.10.y | Present (different SHA1: c081a8228222)
>
> Note: The patch differs from the upstream commit:
> ---
> 1:  6beb6835c1fbb ! 1:  88825867905fa openvswitch: Fix unsafe attribute parsing in output_userspace()
>     @@ Commit message
>          Acked-by: Aaron Conole <aconole@redhat.com>
>          Link: https://patch.msgid.link/0bd65949df61591d9171c0dc13e42cea8941da10.1746541734.git.echaudro@redhat.com
>          Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>     +    (cherry picked from commit 6beb6835c1fbb3f676aebb51a5fee6b77fed9308)

Hi Sasha,

This is my first backport, so can you let me know what the exact tag should be, as I just added the ‘cherry picked’ comment? And do you want a v2?’

>       ## net/openvswitch/actions.c ##
>      @@ net/openvswitch/actions.c: static int output_userspace(struct datapath *dp, struct sk_buff *skb,
>     @@ net/openvswitch/actions.c: static int output_userspace(struct datapath *dp, stru
>       	upcall.mru = OVS_CB(skb)->mru;
>
>      -	for (a = nla_data(attr), rem = nla_len(attr); rem > 0;
>     --	     a = nla_next(a, &rem)) {
>     +-		 a = nla_next(a, &rem)) {
>      +	nla_for_each_nested(a, attr, rem) {
>       		switch (nla_type(a)) {
>       		case OVS_USERSPACE_ATTR_USERDATA:
> ---
>
> Results of testing on various branches:
>
> | Branch                    | Patch Apply | Build Test |
> |---------------------------|-------------|------------|
> | stable/linux-5.4.y        |  Success    |  Success   |