From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, echaudro@redhat.com
Cc: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.4.y] openvswitch: Fix unsafe attribute parsing in output_userspace()
Date: Mon, 12 May 2025 17:52:19 -0400 [thread overview]
Message-ID: <20250512171051-d0977a979bf65698@stable.kernel.org> (raw)
In-Reply-To: <b047b86872e58e15c3b8d3ba394fa1aef4b557ea.1747039582.git.echaudro@redhat.com>
[ Sasha's backport helper bot ]
Hi,
Summary of potential issues:
⚠️ Found matching upstream commit but patch is missing proper reference to it
Found matching upstream commit: 6beb6835c1fbb3f676aebb51a5fee6b77fed9308
Status in newer kernel trees:
6.14.y | Present (different SHA1: 4d184c1b89b8)
6.12.y | Present (different SHA1: 4ae0a4524c47)
6.6.y | Present (different SHA1: 46e070d3714b)
6.1.y | Present (different SHA1: 68544f9fe709)
5.15.y | Present (different SHA1: 99deb2bf2bd1)
5.10.y | Present (different SHA1: c081a8228222)
Note: The patch differs from the upstream commit:
---
1: 6beb6835c1fbb ! 1: 88825867905fa openvswitch: Fix unsafe attribute parsing in output_userspace()
@@ Commit message
Acked-by: Aaron Conole <aconole@redhat.com>
Link: https://patch.msgid.link/0bd65949df61591d9171c0dc13e42cea8941da10.1746541734.git.echaudro@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+ (cherry picked from commit 6beb6835c1fbb3f676aebb51a5fee6b77fed9308)
## net/openvswitch/actions.c ##
@@ net/openvswitch/actions.c: static int output_userspace(struct datapath *dp, struct sk_buff *skb,
@@ net/openvswitch/actions.c: static int output_userspace(struct datapath *dp, stru
upcall.mru = OVS_CB(skb)->mru;
- for (a = nla_data(attr), rem = nla_len(attr); rem > 0;
-- a = nla_next(a, &rem)) {
+- a = nla_next(a, &rem)) {
+ nla_for_each_nested(a, attr, rem) {
switch (nla_type(a)) {
case OVS_USERSPACE_ATTR_USERDATA:
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.4.y | Success | Success |
next prev parent reply other threads:[~2025-05-12 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 8:56 FAILED: patch "[PATCH] openvswitch: Fix unsafe attribute parsing in" failed to apply to 5.4-stable tree gregkh
2025-05-12 8:46 ` [PATCH 5.4.y] openvswitch: Fix unsafe attribute parsing in output_userspace() Eelco Chaudron
2025-05-12 21:52 ` Sasha Levin [this message]
2025-05-13 6:49 ` Eelco Chaudron
2025-05-12 8:50 ` FAILED: patch "[PATCH] openvswitch: Fix unsafe attribute parsing in" failed to apply to 5.4-stable tree Eelco Chaudron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512171051-d0977a979bf65698@stable.kernel.org \
--to=sashal@kernel.org \
--cc=echaudro@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox