* Re: [PATCH 4/4] smb: client: improve DFS mount check
[not found] ` <20230628002450.18781-4-pc@manguebit.com>
@ 2023-07-12 21:10 ` Paulo Alcantara
2023-07-13 5:41 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Paulo Alcantara @ 2023-07-12 21:10 UTC (permalink / raw)
To: stable; +Cc: linux-cifs, Steve French
Paulo Alcantara <pc@manguebit.com> writes:
> Some servers may return error codes from REQ_GET_DFS_REFERRAL requests
> that are unexpected by the client, so to make it easier, assume
> non-DFS mounts when the client can't get the initial DFS referral of
> @ctx->UNC in dfs_mount_share().
>
> Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
> ---
> fs/smb/client/dfs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/smb/client/dfs.c b/fs/smb/client/dfs.c
> index afbaef05a1f1..a7f2e0608adf 100644
Stable team, could you please pick this up as a fix for
8e3554150d6c ("cifs: fix sharing of DFS connections")
The upstream commit is 5f2a0afa9890 ("smb: client: improve DFS mount check").
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] smb: client: improve DFS mount check
2023-07-12 21:10 ` [PATCH 4/4] smb: client: improve DFS mount check Paulo Alcantara
@ 2023-07-13 5:41 ` Greg KH
2023-07-13 21:48 ` Paulo Alcantara
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2023-07-13 5:41 UTC (permalink / raw)
To: Paulo Alcantara; +Cc: stable, linux-cifs, Steve French
On Wed, Jul 12, 2023 at 06:10:27PM -0300, Paulo Alcantara wrote:
> Paulo Alcantara <pc@manguebit.com> writes:
>
> > Some servers may return error codes from REQ_GET_DFS_REFERRAL requests
> > that are unexpected by the client, so to make it easier, assume
> > non-DFS mounts when the client can't get the initial DFS referral of
> > @ctx->UNC in dfs_mount_share().
> >
> > Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
> > ---
> > fs/smb/client/dfs.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/smb/client/dfs.c b/fs/smb/client/dfs.c
> > index afbaef05a1f1..a7f2e0608adf 100644
>
> Stable team, could you please pick this up as a fix for
>
> 8e3554150d6c ("cifs: fix sharing of DFS connections")
>
> The upstream commit is 5f2a0afa9890 ("smb: client: improve DFS mount check").
Does not apply cleanly, can you provide a working backport?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] smb: client: improve DFS mount check
2023-07-13 5:41 ` Greg KH
@ 2023-07-13 21:48 ` Paulo Alcantara
2023-07-16 19:10 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Paulo Alcantara @ 2023-07-13 21:48 UTC (permalink / raw)
To: Greg KH; +Cc: stable, linux-cifs, Steve French
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
Hi Greg,
Greg KH <gregkh@linuxfoundation.org> writes:
> On Wed, Jul 12, 2023 at 06:10:27PM -0300, Paulo Alcantara wrote:
>> Paulo Alcantara <pc@manguebit.com> writes:
>>
>> > Some servers may return error codes from REQ_GET_DFS_REFERRAL requests
>> > that are unexpected by the client, so to make it easier, assume
>> > non-DFS mounts when the client can't get the initial DFS referral of
>> > @ctx->UNC in dfs_mount_share().
>> >
>> > Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
>> > ---
>> > fs/smb/client/dfs.c | 5 +++--
>> > 1 file changed, 3 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/fs/smb/client/dfs.c b/fs/smb/client/dfs.c
>> > index afbaef05a1f1..a7f2e0608adf 100644
>>
>> Stable team, could you please pick this up as a fix for
>>
>> 8e3554150d6c ("cifs: fix sharing of DFS connections")
>>
>> The upstream commit is 5f2a0afa9890 ("smb: client: improve DFS mount check").
>
> Does not apply cleanly, can you provide a working backport?
Find attached backport of
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v6.3-smb-client-improve-DFS-mount-check.patch --]
[-- Type: text/x-patch, Size: 1207 bytes --]
From 435048ee0f477947d1d93f5a9b60b2d2df2b7554 Mon Sep 17 00:00:00 2001
From: Paulo Alcantara <pc@manguebit.com>
Date: Tue, 27 Jun 2023 21:24:50 -0300
Subject: [PATCH stable v6.3] smb: client: improve DFS mount check
Some servers may return error codes from REQ_GET_DFS_REFERRAL requests
that are unexpected by the client, so to make it easier, assume
non-DFS mounts when the client can't get the initial DFS referral of
@ctx->UNC in dfs_mount_share().
Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---
fs/cifs/dfs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/dfs.c b/fs/cifs/dfs.c
index 267536a7531d..fcf536eb5fe1 100644
--- a/fs/cifs/dfs.c
+++ b/fs/cifs/dfs.c
@@ -296,8 +296,9 @@ int dfs_mount_share(struct cifs_mount_ctx *mnt_ctx, bool *isdfs)
if (!nodfs) {
rc = dfs_get_referral(mnt_ctx, ctx->UNC + 1, NULL, NULL);
if (rc) {
- if (rc != -ENOENT && rc != -EOPNOTSUPP && rc != -EIO)
- return rc;
+ cifs_dbg(FYI, "%s: no dfs referral for %s: %d\n",
+ __func__, ctx->UNC + 1, rc);
+ cifs_dbg(FYI, "%s: assuming non-dfs mount...\n", __func__);
nodfs = true;
}
}
--
2.41.0
[-- Attachment #3: Type: text/plain, Size: 416 bytes --]
5f2a0afa9890 ("smb: client: improve DFS mount check").
for v6.3.y.
And for v6.4.y, please take these
d439b29057e2 ("smb: client: fix broken file attrs with nodfs mounts")
49024ec8795e ("smb: client: fix parsing of source mount option")
3ae872de4107 ("smb: client: fix shared DFS root mounts with different prefixes")
49024ec8795e ("smb: client: fix parsing of source mount option")
Thanks.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] smb: client: improve DFS mount check
2023-07-13 21:48 ` Paulo Alcantara
@ 2023-07-16 19:10 ` Greg KH
2023-07-17 15:01 ` Paulo Alcantara
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2023-07-16 19:10 UTC (permalink / raw)
To: Paulo Alcantara; +Cc: stable, linux-cifs, Steve French
On Thu, Jul 13, 2023 at 06:48:00PM -0300, Paulo Alcantara wrote:
> Hi Greg,
>
> Greg KH <gregkh@linuxfoundation.org> writes:
>
> > On Wed, Jul 12, 2023 at 06:10:27PM -0300, Paulo Alcantara wrote:
> >> Paulo Alcantara <pc@manguebit.com> writes:
> >>
> >> > Some servers may return error codes from REQ_GET_DFS_REFERRAL requests
> >> > that are unexpected by the client, so to make it easier, assume
> >> > non-DFS mounts when the client can't get the initial DFS referral of
> >> > @ctx->UNC in dfs_mount_share().
> >> >
> >> > Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
> >> > ---
> >> > fs/smb/client/dfs.c | 5 +++--
> >> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/fs/smb/client/dfs.c b/fs/smb/client/dfs.c
> >> > index afbaef05a1f1..a7f2e0608adf 100644
> >>
> >> Stable team, could you please pick this up as a fix for
> >>
> >> 8e3554150d6c ("cifs: fix sharing of DFS connections")
> >>
> >> The upstream commit is 5f2a0afa9890 ("smb: client: improve DFS mount check").
> >
> > Does not apply cleanly, can you provide a working backport?
>
> Find attached backport of
> >From 435048ee0f477947d1d93f5a9b60b2d2df2b7554 Mon Sep 17 00:00:00 2001
> From: Paulo Alcantara <pc@manguebit.com>
> Date: Tue, 27 Jun 2023 21:24:50 -0300
> Subject: [PATCH stable v6.3] smb: client: improve DFS mount check
I'm confused, 6.3.y is end-of-life, and:
>
> Some servers may return error codes from REQ_GET_DFS_REFERRAL requests
> that are unexpected by the client, so to make it easier, assume
> non-DFS mounts when the client can't get the initial DFS referral of
> @ctx->UNC in dfs_mount_share().
>
> Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> ---
> fs/cifs/dfs.c | 5 +++--
This file is not in the 6.4.y or any older kernel tree.
So what tree did you make this against, and where should it be applied
to?
totally confused,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] smb: client: improve DFS mount check
2023-07-16 19:10 ` Greg KH
@ 2023-07-17 15:01 ` Paulo Alcantara
2023-07-20 17:56 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Paulo Alcantara @ 2023-07-17 15:01 UTC (permalink / raw)
To: Greg KH; +Cc: stable, linux-cifs, Steve French
Greg KH <gregkh@linuxfoundation.org> writes:
> On Thu, Jul 13, 2023 at 06:48:00PM -0300, Paulo Alcantara wrote:
>> Hi Greg,
>>
>> Greg KH <gregkh@linuxfoundation.org> writes:
>>
>> > On Wed, Jul 12, 2023 at 06:10:27PM -0300, Paulo Alcantara wrote:
>> >> Paulo Alcantara <pc@manguebit.com> writes:
>> >>
>> >> > Some servers may return error codes from REQ_GET_DFS_REFERRAL requests
>> >> > that are unexpected by the client, so to make it easier, assume
>> >> > non-DFS mounts when the client can't get the initial DFS referral of
>> >> > @ctx->UNC in dfs_mount_share().
>> >> >
>> >> > Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
>> >> > ---
>> >> > fs/smb/client/dfs.c | 5 +++--
>> >> > 1 file changed, 3 insertions(+), 2 deletions(-)
>> >> >
>> >> > diff --git a/fs/smb/client/dfs.c b/fs/smb/client/dfs.c
>> >> > index afbaef05a1f1..a7f2e0608adf 100644
>> >>
>> >> Stable team, could you please pick this up as a fix for
>> >>
>> >> 8e3554150d6c ("cifs: fix sharing of DFS connections")
>> >>
>> >> The upstream commit is 5f2a0afa9890 ("smb: client: improve DFS mount check").
>> >
>> > Does not apply cleanly, can you provide a working backport?
>>
>> Find attached backport of
>
>> >From 435048ee0f477947d1d93f5a9b60b2d2df2b7554 Mon Sep 17 00:00:00 2001
>> From: Paulo Alcantara <pc@manguebit.com>
>> Date: Tue, 27 Jun 2023 21:24:50 -0300
>> Subject: [PATCH stable v6.3] smb: client: improve DFS mount check
>
> I'm confused, 6.3.y is end-of-life, and:
>
>>
>> Some servers may return error codes from REQ_GET_DFS_REFERRAL requests
>> that are unexpected by the client, so to make it easier, assume
>> non-DFS mounts when the client can't get the initial DFS referral of
>> @ctx->UNC in dfs_mount_share().
>>
>> Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
>> Signed-off-by: Steve French <stfrench@microsoft.com>
>> ---
>> fs/cifs/dfs.c | 5 +++--
>
> This file is not in the 6.4.y or any older kernel tree.
>
> So what tree did you make this against, and where should it be applied
> to?
Err, sorry about missing the EOL of 6.3.y. The attached patch was based
on v6.3.13 from the stable tree[1], where it didn't have the rename
from "fs/cifs" to "fs/smb/client" yet. Please ignore the attached
patch.
So, the commit
5f2a0afa9890 ("smb: client: improve DFS mount check")
should be applied to 6.4.y. I've checked that it applies cleanly
against linux-6.4.y from the linux-stable-rc tree[2].
Thanks.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[2] git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] smb: client: improve DFS mount check
2023-07-17 15:01 ` Paulo Alcantara
@ 2023-07-20 17:56 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2023-07-20 17:56 UTC (permalink / raw)
To: Paulo Alcantara; +Cc: stable, linux-cifs, Steve French
On Mon, Jul 17, 2023 at 12:01:58PM -0300, Paulo Alcantara wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
>
> > On Thu, Jul 13, 2023 at 06:48:00PM -0300, Paulo Alcantara wrote:
> >> Hi Greg,
> >>
> >> Greg KH <gregkh@linuxfoundation.org> writes:
> >>
> >> > On Wed, Jul 12, 2023 at 06:10:27PM -0300, Paulo Alcantara wrote:
> >> >> Paulo Alcantara <pc@manguebit.com> writes:
> >> >>
> >> >> > Some servers may return error codes from REQ_GET_DFS_REFERRAL requests
> >> >> > that are unexpected by the client, so to make it easier, assume
> >> >> > non-DFS mounts when the client can't get the initial DFS referral of
> >> >> > @ctx->UNC in dfs_mount_share().
> >> >> >
> >> >> > Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
> >> >> > ---
> >> >> > fs/smb/client/dfs.c | 5 +++--
> >> >> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >> >> >
> >> >> > diff --git a/fs/smb/client/dfs.c b/fs/smb/client/dfs.c
> >> >> > index afbaef05a1f1..a7f2e0608adf 100644
> >> >>
> >> >> Stable team, could you please pick this up as a fix for
> >> >>
> >> >> 8e3554150d6c ("cifs: fix sharing of DFS connections")
> >> >>
> >> >> The upstream commit is 5f2a0afa9890 ("smb: client: improve DFS mount check").
> >> >
> >> > Does not apply cleanly, can you provide a working backport?
> >>
> >> Find attached backport of
> >
> >> >From 435048ee0f477947d1d93f5a9b60b2d2df2b7554 Mon Sep 17 00:00:00 2001
> >> From: Paulo Alcantara <pc@manguebit.com>
> >> Date: Tue, 27 Jun 2023 21:24:50 -0300
> >> Subject: [PATCH stable v6.3] smb: client: improve DFS mount check
> >
> > I'm confused, 6.3.y is end-of-life, and:
> >
> >>
> >> Some servers may return error codes from REQ_GET_DFS_REFERRAL requests
> >> that are unexpected by the client, so to make it easier, assume
> >> non-DFS mounts when the client can't get the initial DFS referral of
> >> @ctx->UNC in dfs_mount_share().
> >>
> >> Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
> >> Signed-off-by: Steve French <stfrench@microsoft.com>
> >> ---
> >> fs/cifs/dfs.c | 5 +++--
> >
> > This file is not in the 6.4.y or any older kernel tree.
> >
> > So what tree did you make this against, and where should it be applied
> > to?
>
> Err, sorry about missing the EOL of 6.3.y. The attached patch was based
> on v6.3.13 from the stable tree[1], where it didn't have the rename
> from "fs/cifs" to "fs/smb/client" yet. Please ignore the attached
> patch.
>
> So, the commit
>
> 5f2a0afa9890 ("smb: client: improve DFS mount check")
>
> should be applied to 6.4.y. I've checked that it applies cleanly
> against linux-6.4.y from the linux-stable-rc tree[2].
Now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-20 17:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230628002450.18781-1-pc@manguebit.com>
[not found] ` <20230628002450.18781-4-pc@manguebit.com>
2023-07-12 21:10 ` [PATCH 4/4] smb: client: improve DFS mount check Paulo Alcantara
2023-07-13 5:41 ` Greg KH
2023-07-13 21:48 ` Paulo Alcantara
2023-07-16 19:10 ` Greg KH
2023-07-17 15:01 ` Paulo Alcantara
2023-07-20 17:56 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox