From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Fam Zheng <famz@redhat.com>,
Yinghai Lu <yhlu.kernel.send@gmail.com>
Subject: [PATCH v2 0/4] pci: fix unhandled interrupt on shutdown
Date: Thu, 19 Mar 2015 19:57:38 +0100 [thread overview]
Message-ID: <1426786724-22241-1-git-send-email-mst@redhat.com> (raw)
Fam Zheng noticed that pci shutdown disables msi and msix of a device while
device is still active. This was intended to fix kexec with fusion devices but
had the unintended effect of breaking even regular shutdown when using virtio.
The same problem would affect any driver which doesn't register
a level interrupt handler when using msix.
I think the fix is to avoid touching device on shutdown:
we clear bus master anyway, so we won't get any more
msi interrupts, and bus reset will clear the msi/msix
state eventually anyway.
The patches seems to all work well for me. Given they affect all pci devices,
and the bug has been there since 2.6 times, I think there's no rush: we can
merge them for 4.1.
At the same time, once merged, they will likely make a good
stable candidate.
Michael S. Tsirkin (4):
pci: disable msi/msix at probe time
pci: don't disable msi/msix at shutdown
pci: make msi/msix shutdown functions static
virtio_pci: drop msi_off on probe
include/linux/pci.h | 4 ----
drivers/pci/msi.c | 4 ++--
drivers/pci/pci-driver.c | 8 ++++++--
drivers/virtio/virtio_pci_common.c | 3 ---
4 files changed, 8 insertions(+), 11 deletions(-)
--
MST
next reply other threads:[~2015-03-19 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 18:57 Michael S. Tsirkin [this message]
2015-03-19 18:57 ` [PATCH v2 1/4] pci: disable msi/msix at probe time Michael S. Tsirkin
2015-03-23 18:50 ` Bjorn Helgaas
2015-03-23 19:22 ` Michael S. Tsirkin
2015-03-23 20:45 ` Bjorn Helgaas
2015-03-23 20:52 ` Michael S. Tsirkin
2015-03-19 18:58 ` [PATCH v2 2/4] pci: don't disable msi/msix at shutdown Michael S. Tsirkin
2015-03-19 18:58 ` [PATCH v2 3/4] pci: make msi/msix shutdown functions static Michael S. Tsirkin
2015-03-19 18:58 ` [PATCH v2 4/4] virtio_pci: drop msi_off on probe Michael S. Tsirkin
2015-03-23 4:54 ` [PATCH v2 0/4] pci: fix unhandled interrupt on shutdown Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426786724-22241-1-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=bhelgaas@google.com \
--cc=famz@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=yhlu.kernel.send@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox