Linux kernel -stable discussions
 help / color / mirror / Atom feed
* Patch "ext4: fix an endianness bug in ext4_encrypted_zeroout()" has been added to the 4.3-stable tree
@ 2016-02-14 21:04 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-02-14 21:04 UTC (permalink / raw)
  To: viro, gregkh, tytso, viro; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    ext4: fix an endianness bug in ext4_encrypted_zeroout()

to the 4.3-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ext4-fix-an-endianness-bug-in-ext4_encrypted_zeroout.patch
and it can be found in the queue-4.3 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From e2c9e0b28e146c9a3bce21408f3c02e24ac7ac31 Mon Sep 17 00:00:00 2001
From: Al Viro <viro@ZenIV.linux.org.uk>
Date: Thu, 26 Nov 2015 15:20:19 -0500
Subject: ext4: fix an endianness bug in ext4_encrypted_zeroout()

From: Al Viro <viro@ZenIV.linux.org.uk>

commit e2c9e0b28e146c9a3bce21408f3c02e24ac7ac31 upstream.

ex->ee_block is not host-endian (note that accesses of other fields
of *ex right next to that line go through the helpers that do proper
conversion from little-endian to host-endian; it might make sense
to add similar for ->ee_block to avoid reintroducing that kind of
bugs...)

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/ext4/crypto.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/ext4/crypto.c
+++ b/fs/ext4/crypto.c
@@ -408,7 +408,7 @@ int ext4_encrypted_zeroout(struct inode
 	struct ext4_crypto_ctx	*ctx;
 	struct page		*ciphertext_page = NULL;
 	struct bio		*bio;
-	ext4_lblk_t		lblk = ex->ee_block;
+	ext4_lblk_t		lblk = le32_to_cpu(ex->ee_block);
 	ext4_fsblk_t		pblk = ext4_ext_pblock(ex);
 	unsigned int		len = ext4_ext_get_actual_len(ex);
 	int			ret, err = 0;


Patches currently in stable-queue which might be from viro@ZenIV.linux.org.uk are

queue-4.3/ext4-fix-an-endianness-bug-in-ext4_encrypted_follow_link.patch
queue-4.3/ext4-fix-an-endianness-bug-in-ext4_encrypted_zeroout.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-02-14 21:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-14 21:04 Patch "ext4: fix an endianness bug in ext4_encrypted_zeroout()" has been added to the 4.3-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox