public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 1/3] drm/i915/bdw: Add missing delay during L3 SQC credit programming
       [not found] <1462280061-1457-1-git-send-email-imre.deak@intel.com>
@ 2016-05-03 12:54 ` Imre Deak
  0 siblings, 0 replies; only message in thread
From: Imre Deak @ 2016-05-03 12:54 UTC (permalink / raw)
  To: intel-gfx; +Cc: stable, Ville Syrjälä

BSpec requires us to wait ~100 clocks before re-enabling clock gating,
so make sure we do this.

CC: stable@vger.kernel.org
CC: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 2422ac3..227cd2d 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -6738,6 +6738,12 @@ static void broadwell_init_clock_gating(struct drm_device *dev)
 	misccpctl = I915_READ(GEN7_MISCCPCTL);
 	I915_WRITE(GEN7_MISCCPCTL, misccpctl & ~GEN7_DOP_CLOCK_GATE_ENABLE);
 	I915_WRITE(GEN8_L3SQCREG1, BDW_WA_L3SQCREG1_DEFAULT);
+	/*
+	 * Wait at least 100 clocks before re-enabling clock gating. See
+	 * the definition of L3SQCREG1 in BSpec.
+	 */
+	POSTING_READ(GEN8_L3SQCREG1);
+	udelay(1);
 	I915_WRITE(GEN7_MISCCPCTL, misccpctl);
 
 	/*
-- 
2.5.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-05-03 12:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1462280061-1457-1-git-send-email-imre.deak@intel.com>
2016-05-03 12:54 ` [PATCH v3 1/3] drm/i915/bdw: Add missing delay during L3 SQC credit programming Imre Deak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox