* Patch "pinctrl: at91-pio4: fix pull-up/down logic" has been added to the 4.5-stable tree
@ 2016-05-15 0:00 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-05-15 0:00 UTC (permalink / raw)
To: ludovic.desroches, alexandre.belloni, gregkh, linus.walleij,
nicolas.ferre
Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
pinctrl: at91-pio4: fix pull-up/down logic
to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
pinctrl-at91-pio4-fix-pull-up-down-logic.patch
and it can be found in the queue-4.5 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 5305a7b7e860bb40ab226bc7d58019416073948a Mon Sep 17 00:00:00 2001
From: Ludovic Desroches <ludovic.desroches@atmel.com>
Date: Tue, 19 Apr 2016 16:03:45 +0200
Subject: pinctrl: at91-pio4: fix pull-up/down logic
From: Ludovic Desroches <ludovic.desroches@atmel.com>
commit 5305a7b7e860bb40ab226bc7d58019416073948a upstream.
The default configuration of a pin is often with a value in the
pull-up/down field at chip reset. So, even if the internal logic of the
controller prevents writing a configuration with pull-up and pull-down at
the same time, we must ensure explicitly this condition before writing the
register.
This was leading to a pull-down condition not taken into account for
instance.
Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Fixes: 776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller")
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/pinctrl/pinctrl-at91-pio4.c | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/pinctrl/pinctrl-at91-pio4.c
+++ b/drivers/pinctrl/pinctrl-at91-pio4.c
@@ -722,9 +722,11 @@ static int atmel_conf_pin_config_group_s
break;
case PIN_CONFIG_BIAS_PULL_UP:
conf |= ATMEL_PIO_PUEN_MASK;
+ conf &= (~ATMEL_PIO_PDEN_MASK);
break;
case PIN_CONFIG_BIAS_PULL_DOWN:
conf |= ATMEL_PIO_PDEN_MASK;
+ conf &= (~ATMEL_PIO_PUEN_MASK);
break;
case PIN_CONFIG_DRIVE_OPEN_DRAIN:
if (arg == 0)
Patches currently in stable-queue which might be from ludovic.desroches@atmel.com are
queue-4.5/pinctrl-at91-pio4-fix-pull-up-down-logic.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-05-15 0:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-15 0:00 Patch "pinctrl: at91-pio4: fix pull-up/down logic" has been added to the 4.5-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox