Patch "decnet: Do not build routes to devices without decnet private data." has been added to the 3.14-stable tree

Patch "decnet: Do not build routes to devices without decnet private data." has been added to the 3.14-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    decnet: Do not build routes to devices without decnet private data.

to the 3.14-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     decnet-do-not-build-routes-to-devices-without-decnet-private-data.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Mon May 16 14:28:52 PDT 2016
From: "David S. Miller" <davem@davemloft.net>
Date: Sun, 10 Apr 2016 23:01:30 -0400
Subject: decnet: Do not build routes to devices without decnet private data.
Status: RO
Content-Length: 1298
Lines: 50

From: "David S. Miller" <davem@davemloft.net>

[ Upstream commit a36a0d4008488fa545c74445d69eaf56377d5d4e ]

In particular, make sure we check for decnet private presence
for loopback devices.

Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 net/decnet/dn_route.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -1030,10 +1030,13 @@ source_ok:
 	if (!fld.daddr) {
 		fld.daddr = fld.saddr;
 
-		err = -EADDRNOTAVAIL;
 		if (dev_out)
 			dev_put(dev_out);
+		err = -EINVAL;
 		dev_out = init_net.loopback_dev;
+		if (!dev_out->dn_ptr)
+			goto out;
+		err = -EADDRNOTAVAIL;
 		dev_hold(dev_out);
 		if (!fld.daddr) {
 			fld.daddr =
@@ -1106,6 +1109,8 @@ source_ok:
 		if (dev_out == NULL)
 			goto out;
 		dn_db = rcu_dereference_raw(dev_out->dn_ptr);
+		if (!dn_db)
+			goto e_inval;
 		/* Possible improvement - check all devices for local addr */
 		if (dn_dev_islocal(dev_out, fld.daddr)) {
 			dev_put(dev_out);
@@ -1147,6 +1152,8 @@ select_source:
 			dev_put(dev_out);
 		dev_out = init_net.loopback_dev;
 		dev_hold(dev_out);
+		if (!dev_out->dn_ptr)
+			goto e_inval;
 		fld.flowidn_oif = dev_out->ifindex;
 		if (res.fi)
 			dn_fib_info_put(res.fi);


Patches currently in stable-queue which might be from davem@davemloft.net are

queue-3.14/route-do-not-cache-fib-route-info-on-local-routes-with-oif.patch
queue-3.14/packet-fix-heap-info-leak-in-packet_diag_mclist-sock_diag-interface.patch
queue-3.14/atl2-disable-unimplemented-scatter-gather-feature.patch
queue-3.14/vsock-do-not-disconnect-socket-when-peer-has-shutdown-send-only.patch
queue-3.14/net-bridge-fix-old-ioctl-unlocked-net-device-walk.patch
queue-3.14/net-fix-a-kernel-infoleak-in-x25-module.patch
queue-3.14/decnet-do-not-build-routes-to-devices-without-decnet-private-data.patch
queue-3.14/net-fix-infoleak-in-llc.patch
queue-3.14/net-fix-infoleak-in-rtnetlink.patch