* Patch "btrfs: reada: Fix in-segment calculation for reada" has been added to the 4.5-stable tree
@ 2016-05-17 0:01 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-05-17 0:01 UTC (permalink / raw)
To: zhaolei, dsterba, gregkh; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
btrfs: reada: Fix in-segment calculation for reada
to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
btrfs-reada-fix-in-segment-calculation-for-reada.patch
and it can be found in the queue-4.5 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 503785306d182ab624a2232856ef8ab503ee85f9 Mon Sep 17 00:00:00 2001
From: Zhao Lei <zhaolei@cn.fujitsu.com>
Date: Fri, 18 Dec 2015 21:33:05 +0800
Subject: btrfs: reada: Fix in-segment calculation for reada
From: Zhao Lei <zhaolei@cn.fujitsu.com>
commit 503785306d182ab624a2232856ef8ab503ee85f9 upstream.
reada_zone->end is end pos of segment:
end = start + cache->key.offset - 1;
So we need to use "<=" in condition to judge is a pos in the
segment.
The problem happened rearly, because logical pos rarely pointed
to last 4k of a blockgroup, but we need to fix it to make code
right in logic.
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
fs/btrfs/reada.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/fs/btrfs/reada.c
+++ b/fs/btrfs/reada.c
@@ -265,7 +265,7 @@ static struct reada_zone *reada_find_zon
spin_unlock(&fs_info->reada_lock);
if (ret == 1) {
- if (logical >= zone->start && logical < zone->end)
+ if (logical >= zone->start && logical <= zone->end)
return zone;
spin_lock(&fs_info->reada_lock);
kref_put(&zone->refcnt, reada_zone_release);
@@ -679,7 +679,7 @@ static int reada_start_machine_dev(struc
*/
ret = radix_tree_gang_lookup(&dev->reada_extents, (void **)&re,
dev->reada_next >> PAGE_CACHE_SHIFT, 1);
- if (ret == 0 || re->logical >= dev->reada_curr_zone->end) {
+ if (ret == 0 || re->logical > dev->reada_curr_zone->end) {
ret = reada_pick_zone(dev);
if (!ret) {
spin_unlock(&fs_info->reada_lock);
Patches currently in stable-queue which might be from zhaolei@cn.fujitsu.com are
queue-4.5/btrfs-reada-fix-in-segment-calculation-for-reada.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-05-17 0:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-17 0:01 Patch "btrfs: reada: Fix in-segment calculation for reada" has been added to the 4.5-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox