From: Oliver Neukum <oneukum@suse.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] cdc-wdm: fix "out-of-sync" due to missing notifications
Date: Tue, 17 May 2016 11:13:58 +0200 [thread overview]
Message-ID: <1463476438.19237.3.camel@suse.com> (raw)
In-Reply-To: <87mvntevwy.fsf@nemi.mork.no>
On Fri, 2016-05-13 at 18:59 +0200, Bjørn Mork wrote:
> Bjørn Mork <bjorn@mork.no> writes:
>
> > The driver enforces a strict one-to-one relationship between the
> > received RESPONSE_AVAILABLE notifications and messages read from
> > the device. At the same time, it will cancel the interrupt URB
> > when there is no client holding the character device open.
>
> Never mind. Forget it.
>
> This patch breaks other devices again. The immediate and unconditional
> reading make them barf. I guess it can be worked around by delaying the
> flushing until at least one notification is received, but I obviously
> have to test this theory thoroughly on all devices I have.
Hi,
I think the best approach would be to keep the interrupt URB always
active. I didn't do this to conserve bandwidth, but if it makes devices
work, it certainly would be the best option.
Regards
Oliver
next prev parent reply other threads:[~2016-05-17 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 15:39 [PATCH] cdc-wdm: fix "out-of-sync" due to missing notifications Bjørn Mork
2016-05-13 16:59 ` Bjørn Mork
2016-05-17 9:13 ` Oliver Neukum [this message]
2016-05-17 19:24 ` Bjørn Mork
2016-05-17 21:49 ` Oliver Neukum
2016-05-17 23:39 ` Bjørn Mork
2016-05-18 8:12 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463476438.19237.3.camel@suse.com \
--to=oneukum@suse.com \
--cc=bjorn@mork.no \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox