* [PATCH] cpufreq: imx6: Fix the secondary_sel_clk clock string
@ 2016-05-20 2:59 Fabio Estevam
2016-05-20 3:03 ` Viresh Kumar
2016-05-20 3:09 ` Fabio Estevam
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-05-20 2:59 UTC (permalink / raw)
To: rafael.j.wysocki
Cc: viresh.kumar, ping.bai, shawnguo, kernel, linux-pm, Fabio Estevam,
stable
From: Fabio Estevam <fabio.estevam@nxp.com>
Commit a35fc5a33b62a6 ("cpufreq: imx: update the clock switch flow to
support imx6ul") introduced the 'secondary_sel_clk' clock, which is
specific for the i.mx6ul case, but used the wrong clock string inside
the clk_get() function.
Use the correct clock string: "secondary_sel_clk".
This fixes a kernel crash after running the 'reboot' command on a
mx6ul.
Fixes: a35fc5a33b62a6 ("cpufreq: imx: update the clock switch flow to support imx6ul")
Cc: <stable@vger.kernel.org> # 4.4.x
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/cpufreq/imx6q-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c
index ef1fa81..00b481e 100644
--- a/drivers/cpufreq/imx6q-cpufreq.c
+++ b/drivers/cpufreq/imx6q-cpufreq.c
@@ -212,7 +212,7 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev)
if (of_machine_is_compatible("fsl,imx6ul")) {
pll2_bus_clk = clk_get(cpu_dev, "pll2_bus");
- secondary_sel_clk = clk_get(cpu_dev, "secondary_sel");
+ secondary_sel_clk = clk_get(cpu_dev, "secondary_sel_clk");
if (IS_ERR(pll2_bus_clk) || IS_ERR(secondary_sel_clk)) {
dev_err(cpu_dev, "failed to get clocks specific to imx6ul\n");
ret = -ENOENT;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cpufreq: imx6: Fix the secondary_sel_clk clock string
2016-05-20 2:59 [PATCH] cpufreq: imx6: Fix the secondary_sel_clk clock string Fabio Estevam
@ 2016-05-20 3:03 ` Viresh Kumar
2016-05-20 3:09 ` Fabio Estevam
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2016-05-20 3:03 UTC (permalink / raw)
To: Fabio Estevam
Cc: rafael.j.wysocki, ping.bai, shawnguo, kernel, linux-pm,
Fabio Estevam, stable
On 19-05-16, 23:59, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit a35fc5a33b62a6 ("cpufreq: imx: update the clock switch flow to
> support imx6ul") introduced the 'secondary_sel_clk' clock, which is
> specific for the i.mx6ul case, but used the wrong clock string inside
> the clk_get() function.
>
> Use the correct clock string: "secondary_sel_clk".
>
> This fixes a kernel crash after running the 'reboot' command on a
> mx6ul.
>
> Fixes: a35fc5a33b62a6 ("cpufreq: imx: update the clock switch flow to support imx6ul")
> Cc: <stable@vger.kernel.org> # 4.4.x
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cpufreq: imx6: Fix the secondary_sel_clk clock string
2016-05-20 2:59 [PATCH] cpufreq: imx6: Fix the secondary_sel_clk clock string Fabio Estevam
2016-05-20 3:03 ` Viresh Kumar
@ 2016-05-20 3:09 ` Fabio Estevam
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-05-20 3:09 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Viresh Kumar, Ping Bai, Shawn Guo, Sascha Hauer,
linux-pm@vger.kernel.org, Fabio Estevam, stable
On Thu, May 19, 2016 at 11:59 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit a35fc5a33b62a6 ("cpufreq: imx: update the clock switch flow to
> support imx6ul") introduced the 'secondary_sel_clk' clock, which is
> specific for the i.mx6ul case, but used the wrong clock string inside
> the clk_get() function.
>
> Use the correct clock string: "secondary_sel_clk".
Sorry, the 'secondary_sel' name is the one define in imx6ul.dtsi.
This patch 'fixed' the issue because it did not register cpufreq for mx6ul.
We still need to provide a proper fix for cpufreq on mx6ul. Please
discard this patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-20 3:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-20 2:59 [PATCH] cpufreq: imx6: Fix the secondary_sel_clk clock string Fabio Estevam
2016-05-20 3:03 ` Viresh Kumar
2016-05-20 3:09 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox