From: Max Gurtovoy <maxg@mellanox.com>
To: matanb@mellanox.com, leon@leon.nu, sagi@grimberg.me,
linux-rdma@vger.kernel.org
Cc: stable@vger.kernel.org, robert@leblancnet.us,
Max Gurtovoy <maxg@mellanox.com>
Subject: [PATCH] IB/core: Fix bit curruption in ib_device_cap_flags structure
Date: Thu, 2 Jun 2016 12:28:05 +0300 [thread overview]
Message-ID: <1464859685-18666-1-git-send-email-maxg@mellanox.com> (raw)
ib_device_cap_flags 64-bit expansion caused caps overlapping
and made consumers read wrong device capabilities. For example
IB_DEVICE_SG_GAPS_REG was falsely read by the iser driver causing
it to use a non-existing capability. This happened because signed
int becomes sign extended when converted it to u64. Fix this by
casting IB_DEVICE_ON_DEMAND_PAGING enumeration to ULL.
Fixes: fb532d6a79b9 ('IB/{core, ulp} Support above 32 possible device capability flags')
Reported-by: Robert LeBlanc <robert@leblancnet.us>
Cc: Stable <stable@vger.kernel.org> #[v4.6+]
Acked-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Matan Barak <matanb@mellanox.com>
---
include/rdma/ib_verbs.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 432bed5..c97357b 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -217,7 +217,7 @@ enum ib_device_cap_flags {
IB_DEVICE_CROSS_CHANNEL = (1 << 27),
IB_DEVICE_MANAGED_FLOW_STEERING = (1 << 29),
IB_DEVICE_SIGNATURE_HANDOVER = (1 << 30),
- IB_DEVICE_ON_DEMAND_PAGING = (1 << 31),
+ IB_DEVICE_ON_DEMAND_PAGING = (1ULL << 31),
IB_DEVICE_SG_GAPS_REG = (1ULL << 32),
IB_DEVICE_VIRTUAL_FUNCTION = ((u64)1 << 33),
IB_DEVICE_RAW_SCATTER_FCS = ((u64)1 << 34),
--
1.7.1
next reply other threads:[~2016-06-02 9:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 9:28 Max Gurtovoy [this message]
2016-06-02 11:33 ` [PATCH] IB/core: Fix bit curruption in ib_device_cap_flags structure Christoph Hellwig
2016-06-02 11:48 ` Max Gurtovoy
2016-06-02 11:56 ` Sagi Grimberg
2016-06-02 16:51 ` Jason Gunthorpe
2016-06-02 16:24 ` Greg KH
2016-06-02 16:41 ` Bart Van Assche
2016-06-02 16:52 ` Greg KH
2016-06-02 16:41 ` Max Gurtovoy
2016-06-02 16:52 ` Greg KH
2016-06-02 16:48 ` Christoph Lameter
2016-06-02 16:52 ` Jason Gunthorpe
2016-06-03 10:47 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464859685-18666-1-git-send-email-maxg@mellanox.com \
--to=maxg@mellanox.com \
--cc=leon@leon.nu \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=robert@leblancnet.us \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox