From: Max Gurtovoy <maxg@mellanox.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <matanb@mellanox.com>, <leon@leon.nu>, <sagi@grimberg.me>,
<linux-rdma@vger.kernel.org>, <stable@vger.kernel.org>,
<robert@leblancnet.us>
Subject: Re: [PATCH] IB/core: Fix bit curruption in ib_device_cap_flags structure
Date: Thu, 2 Jun 2016 14:48:28 +0300 [thread overview]
Message-ID: <57501D0C.9020607@mellanox.com> (raw)
In-Reply-To: <20160602113353.GA18494@infradead.org>
On 6/2/2016 2:33 PM, Christoph Hellwig wrote:
>> IB_DEVICE_CROSS_CHANNEL = (1 << 27),
>> IB_DEVICE_MANAGED_FLOW_STEERING = (1 << 29),
>> IB_DEVICE_SIGNATURE_HANDOVER = (1 << 30),
>> - IB_DEVICE_ON_DEMAND_PAGING = (1 << 31),
>> + IB_DEVICE_ON_DEMAND_PAGING = (1ULL << 31),
>> IB_DEVICE_SG_GAPS_REG = (1ULL << 32),
>> IB_DEVICE_VIRTUAL_FUNCTION = ((u64)1 << 33),
>> IB_DEVICE_RAW_SCATTER_FCS = ((u64)1 << 34),
>
> So now we've got three different styles to define the constants.
My next patch will align casting of IB_DEVICE_VIRTUAL_FUNCTION and
IB_DEVICE_RAW_SCATTER_FCS to ULL.
>
> I'd really prefer to move all of them over to the 1ULL << offset style.
me too :)
>
next prev parent reply other threads:[~2016-06-02 14:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 9:28 [PATCH] IB/core: Fix bit curruption in ib_device_cap_flags structure Max Gurtovoy
2016-06-02 11:33 ` Christoph Hellwig
2016-06-02 11:48 ` Max Gurtovoy [this message]
2016-06-02 11:56 ` Sagi Grimberg
2016-06-02 16:51 ` Jason Gunthorpe
2016-06-02 16:24 ` Greg KH
2016-06-02 16:41 ` Bart Van Assche
2016-06-02 16:52 ` Greg KH
2016-06-02 16:41 ` Max Gurtovoy
2016-06-02 16:52 ` Greg KH
2016-06-02 16:48 ` Christoph Lameter
2016-06-02 16:52 ` Jason Gunthorpe
2016-06-03 10:47 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57501D0C.9020607@mellanox.com \
--to=maxg@mellanox.com \
--cc=hch@infradead.org \
--cc=leon@leon.nu \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=robert@leblancnet.us \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox