From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@nbd.name>,
Greg KH <gregkh@linuxfoundation.org>,
Marc Zyngier <marc.zyngier@arm.com>
Cc: christoffer.dall@linaro.org, tglx@linutronix.de, tn@semihalf.com,
stable@vger.kernel.org, stable-commits@vger.kernel.org
Subject: Re: Patch "hrtimer: Add support for CLOCK_MONOTONIC_RAW" has been added to the 4.4-stable tree
Date: Tue, 27 Sep 2016 22:06:06 +0200 [thread overview]
Message-ID: <1475006766.5141.42.camel@sipsolutions.net> (raw)
In-Reply-To: <82143295-0fa6-6d19-4f92-e3973c607632@nbd.name>
On Tue, 2016-09-27 at 21:55 +0200, Felix Fietkau wrote:
> > > Please drop that patch. It is utterly broken, and was reverted in
> > > mainline with commit 82e88ff1ea94 ("hrtimer: Revert
> > > CLOCK_MONOTONIC_RAW support").
Probably shouldn't be discussing it in this context, but ...
Why did this also revert the illegal clock ID catching? That seems
strange? Doesn't that mean that everything that specifies an otherwise
not supported value will get HRTIMER_BASE_MONOTONIC?
> > Ok, will do.
> >
> > Felix, this kind of means this isn't the fix you were looking for,
> > any
> > other ideas?
> I guess I can send a mac80211_hwpatch to switch to CLOCK_MONOTONIC
> instead and add Cc: stable.
I had actually selected _RAW for a reason, you don't want the frame
timings to be affected by clock adjustments?
Arguably, it's rare that the clock is actually adjusted, and even if
that does happen, chances are that nobody will actually care at that
point in time, but ...
What would it take to actually add real support?
johannes
prev parent reply other threads:[~2016-09-27 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 14:27 Patch "hrtimer: Add support for CLOCK_MONOTONIC_RAW" has been added to the 4.4-stable tree gregkh
2016-09-27 16:12 ` Marc Zyngier
2016-09-27 18:03 ` Greg KH
2016-09-27 19:55 ` Felix Fietkau
2016-09-27 20:06 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475006766.5141.42.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=christoffer.dall@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=marc.zyngier@arm.com \
--cc=nbd@nbd.name \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tn@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox