Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Ron Economos <re@w6rz.net>
To: Greg KH <greg@kroah.com>
Cc: Xingyu Wu <xingyu.wu@starfivetech.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"stable-commits@vger.kernel.org" <stable-commits@vger.kernel.org>,
	Sasha Levin <sashal@kernel.org>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Conor Dooley <conor@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Hal Feng <hal.feng@starfivetech.com>
Subject: Re: Patch "riscv: dts: starfive: jh7110-common: Fix lower rate of CPUfreq by setting PLL0 rate to 1.5GHz" has been added to the 6.10-stable tree
Date: Sun, 15 Sep 2024 08:01:33 -0700	[thread overview]
Message-ID: <148a908f-e2e2-6001-510e-73aef81d07b5@w6rz.net> (raw)
In-Reply-To: <2024091501-dreamland-driveway-e0c3@gregkh>

On 9/15/24 6:22 AM, Greg KH wrote:
> On Sat, Sep 14, 2024 at 03:32:33AM -0700, Ron Economos wrote:
>> On 9/14/24 3:04 AM, Xingyu Wu wrote:
>>> On 14/09/2024 17:37, Greg KH wrote:
>>>> On Sat, Sep 14, 2024 at 09:24:44AM +0000, Xingyu Wu wrote:
>>>>> On 14/09/2024 16:51, Greg KH wrote:
>>>>>> On Sat, Sep 14, 2024 at 08:01:44AM +0000, Xingyu Wu wrote:
>>>>>>> On 13/09/2024 22:12, Sasha Levin wrote:
>>>>>>>> This is a note to let you know that I've just added the patch
>>>>>>>> titled
>>>>>>>>
>>>>>>>>       riscv: dts: starfive: jh7110-common: Fix lower rate of
>>>>>>>> CPUfreq by setting PLL0 rate to 1.5GHz
>>>>>>>>
>>>>>>>> to the 6.10-stable tree which can be found at:
>>>>>>>>       http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-
>>>>>>>> queue.git;a=summary
>>>>>>>>
>>>>>>>> The filename of the patch is:
>>>>>>>>        riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.patch
>>>>>>>> and it can be found in the queue-6.10 subdirectory.
>>>>>>>>
>>>>>>>> If you, or anyone else, feels it should not be added to the
>>>>>>>> stable tree, please let <stable@vger.kernel.org> know about it.
>>>>>>>>
>>>>>>> Hi Sasha,
>>>>>>>
>>>>>>> This patch only has the part of DTS without the clock driver patch[1].
>>>>>>> [1]:
>>>>>>> https://lore.kernel.org/all/20240826080430.179788-2-xingyu.wu@star
>>>>>>> five
>>>>>>> tech.com/
>>>>>>>
>>>>>>> I don't know your plan about this driver patch, or maybe I missed it.
>>>>>>> But the DTS changes really needs the driver patch to work and you
>>>>>>> should add
>>>>>> the driver patch.
>>>>>>
>>>>>> Then why does the commit say:
>>>>>>
>>>>>>>>       Fixes: e2c510d6d630 ("riscv: dts: starfive: Add cpu scaling
>>>>>>>> for
>>>>>>>> JH7110 SoC")
>>>>>> Is that line incorrect?
>>>>>>
>>>>> No, this patch can also fix the problem.
>>>>> In that patchset, the patch 2 depended on patch 1,  so I added the Fixes tag in
>>>> both patches.
>>>>
>>>> What is the commit id of the other change you are referring to here?
>>>>
>>> This commit id is the bug I'm trying to fix. The Fixes tag need to add it.
>>>
>>> Thanks,
>>> Xingyu Wu
>>>
>> I think Greg is looking for this:
>>
>> commit 538d5477b25289ac5d46ca37b9e5b4d685cbe019
>>
>> clk: starfive: jh7110-sys: Add notifier for PLL0 clock
> That commit is already in the following releases:
> 	6.6.51 6.10.10
> so what are we supposed to be doing here?
>
> confused,
>
> greg k-h
>
Sorry, I didn't check to see if it was already in releases. So the 6.10 
queue is fine as is.

However, these two patches go together, so the 6.6 queue should also 
have 61f2e8a3a94175dbbaad6a54f381b2a505324610 "riscv: dts: starfive: 
jh7110-common: Fix lower rate of CPUfreq by setting PLL0 rate to 1.5GHz" 
added to it.

Does that make sense?



  reply	other threads:[~2024-09-15 15:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240913141134.2831322-1-sashal@kernel.org>
2024-09-14  8:01 ` Patch "riscv: dts: starfive: jh7110-common: Fix lower rate of CPUfreq by setting PLL0 rate to 1.5GHz" has been added to the 6.10-stable tree Xingyu Wu
2024-09-14  8:51   ` Greg KH
2024-09-14  9:24     ` Xingyu Wu
2024-09-14  9:37       ` Greg KH
2024-09-14 10:04         ` Xingyu Wu
2024-09-14 10:32           ` Ron Economos
2024-09-15 13:22             ` Greg KH
2024-09-15 15:01               ` Ron Economos [this message]
2024-09-15 15:10                 ` Greg KH
2024-09-15 15:17                   ` Ron Economos
2024-09-18  2:54                   ` Xingyu Wu
2024-09-18  6:16                     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=148a908f-e2e2-6001-510e-73aef81d07b5@w6rz.net \
    --to=re@w6rz.net \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor@kernel.org \
    --cc=greg@kroah.com \
    --cc=hal.feng@starfivetech.com \
    --cc=kernel@esmil.dk \
    --cc=krzk+dt@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=xingyu.wu@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox