Re: Patch "riscv: dts: starfive: jh7110-common: Fix lower rate of CPUfreq by setting PLL0 rate to 1.5GHz" has been added to the 6.10-stable tree

[Greg KH <greg@kroah.com>]

On Wed, Sep 18, 2024 at 02:54:57AM +0000, Xingyu Wu wrote:
> On 9/15/24 23:10 AM, Greg KH wrote:
> > 
> > On Sun, Sep 15, 2024 at 08:01:33AM -0700, Ron Economos wrote:
> > > On 9/15/24 6:22 AM, Greg KH wrote:
> > > > On Sat, Sep 14, 2024 at 03:32:33AM -0700, Ron Economos wrote:
> > > > > On 9/14/24 3:04 AM, Xingyu Wu wrote:
> > > > > > On 14/09/2024 17:37, Greg KH wrote:
> > > > > > > On Sat, Sep 14, 2024 at 09:24:44AM +0000, Xingyu Wu wrote:
> > > > > > > > On 14/09/2024 16:51, Greg KH wrote:
> > > > > > > > > On Sat, Sep 14, 2024 at 08:01:44AM +0000, Xingyu Wu wrote:
> > > > > > > > > > On 13/09/2024 22:12, Sasha Levin wrote:
> > > > > > > > > > > This is a note to let you know that I've just added
> > > > > > > > > > > the patch titled
> > > > > > > > > > >
> > > > > > > > > > >       riscv: dts: starfive: jh7110-common: Fix lower
> > > > > > > > > > > rate of CPUfreq by setting PLL0 rate to 1.5GHz
> > > > > > > > > > >
> > > > > > > > > > > to the 6.10-stable tree which can be found at:
> > > > > > > > > > >
> > > > > > > > > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/s
> > > > > > > > > > > table-
> > > > > > > > > > > queue.git;a=summary
> > > > > > > > > > >
> > > > > > > > > > > The filename of the patch is:
> > > > > > > > > > >
> > > > > > > > > > > riscv-dts-starfive-jh7110-common-fix-lower-rate-of-c.p
> > > > > > > > > > > atch and it can be found in the queue-6.10
> > > > > > > > > > > subdirectory.
> > > > > > > > > > >
> > > > > > > > > > > If you, or anyone else, feels it should not be added
> > > > > > > > > > > to the stable tree, please let <stable@vger.kernel.org> know
> > about it.
> > > > > > > > > > >
> > > > > > > > > > Hi Sasha,
> > > > > > > > > >
> > > > > > > > > > This patch only has the part of DTS without the clock driver
> > patch[1].
> > > > > > > > > > [1]:
> > > > > > > > > > https://lore.kernel.org/all/20240826080430.179788-2-xing
> > > > > > > > > > yu.wu@star
> > > > > > > > > > five
> > > > > > > > > > tech.com/
> > > > > > > > > >
> > > > > > > > > > I don't know your plan about this driver patch, or maybe I missed it.
> > > > > > > > > > But the DTS changes really needs the driver patch to
> > > > > > > > > > work and you should add
> > > > > > > > > the driver patch.
> > > > > > > > >
> > > > > > > > > Then why does the commit say:
> > > > > > > > >
> > > > > > > > > > >       Fixes: e2c510d6d630 ("riscv: dts: starfive: Add
> > > > > > > > > > > cpu scaling for
> > > > > > > > > > > JH7110 SoC")
> > > > > > > > > Is that line incorrect?
> > > > > > > > >
> > > > > > > > No, this patch can also fix the problem.
> > > > > > > > In that patchset, the patch 2 depended on patch 1,  so I
> > > > > > > > added the Fixes tag in
> > > > > > > both patches.
> > > > > > >
> > > > > > > What is the commit id of the other change you are referring to here?
> > > > > > >
> > > > > > This commit id is the bug I'm trying to fix. The Fixes tag need to add it.
> > > > > >
> > > > > > Thanks,
> > > > > > Xingyu Wu
> > > > > >
> > > > > I think Greg is looking for this:
> > > > >
> > > > > commit 538d5477b25289ac5d46ca37b9e5b4d685cbe019
> > > > >
> > > > > clk: starfive: jh7110-sys: Add notifier for PLL0 clock
> > > > That commit is already in the following releases:
> > > > 	6.6.51 6.10.10
> > > > so what are we supposed to be doing here?
> > > >
> > > > confused,
> > > >
> > > > greg k-h
> > > >
> > > Sorry, I didn't check to see if it was already in releases. So the
> > > 6.10 queue is fine as is.
> > >
> > > However, these two patches go together, so the 6.6 queue should also
> > > have
> > > 61f2e8a3a94175dbbaad6a54f381b2a505324610 "riscv: dts: starfive:
> > > jh7110-common: Fix lower rate of CPUfreq by setting PLL0 rate to 1.5GHz"
> > > added to it.
> > 
> > Given that the file arch/riscv/boot/dts/starfive/jh7110-common.dtsi is not in the
> > 6.6.y kernel tree, are you sure about this?  If so, where should it be applied to
> > instead?
> > 
> 
> Hi Greg,
> 
> How about this patch[1] which I sent earlier about DTS?
> [1]: https://lore.kernel.org/all/20240507065319.274976-3-xingyu.wu@starfivetech.com/
> 
> This patch is based on older kernel without the file (jh7110-common.dtsi) and has been tested to work.

If you think it fits the rules of:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
then great, resubmit it!

thanks,

greg k-h