From: Ben Hutchings <ben@decadent.org.uk>
To: Jeff Mahoney <jeffm@suse.com>, stable@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>
Subject: Re: [PATCH] Btrfs: don't use src fd for printk
Date: Sun, 08 Oct 2017 21:57:17 +0100 [thread overview]
Message-ID: <1507496237.2677.92.camel@decadent.org.uk> (raw)
In-Reply-To: <d3e95857-6450-e692-d93c-52158b8aa145@suse.com>
[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]
On Tue, 2016-05-17 at 09:36 -0400, Jeff Mahoney wrote:
> From: Josef Bacik <jbacik@fb.com>
>
> [ Upstream commit c79b4713304f812d3d6c95826fc3e5fc2c0b0c14 ]
>
> The fd we pass in may not be on a btrfs file system, so don't try to do
> BTRFS_I() on it. Thanks,
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
> Reviewed-by: David Sterba <dsterba@suse.com>
> Signed-off-by: David Sterba <dsterba@suse.com>
> Cc: stable@vger.kernel.org # 3.14+
Belatedly queued up for 3.16, thanks.
Ben.
> ---
> fs/btrfs/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 053e677..21423dd 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -1654,7 +1654,7 @@ static noinline int btrfs_ioctl_snap_create_transid(struct file *file,
>
> src_inode = file_inode(src.file);
> if (src_inode->i_sb != file_inode(file)->i_sb) {
> - btrfs_info(BTRFS_I(src_inode)->root->fs_info,
> + btrfs_info(BTRFS_I(file_inode(file))->root->fs_info,
> "Snapshot src from another FS");
> ret = -EXDEV;
> } else if (!inode_owner_or_capable(src_inode)) {
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben Hutchings
compatible: Gracefully accepts erroneous data from any source
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-10-08 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 13:36 [PATCH] Btrfs: don't use src fd for printk Jeff Mahoney
2016-05-17 16:18 ` David Sterba
2017-10-08 20:57 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507496237.2677.92.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=dsterba@suse.com \
--cc=jeffm@suse.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox