Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, Su Yue <suy.fnst@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [stable] btrfs name length fixes
Date: Mon, 30 Oct 2017 00:19:42 +0000	[thread overview]
Message-ID: <1509322782.2721.74.camel@decadent.org.uk> (raw)
In-Reply-To: <bce85efc-21e6-e5b6-e26a-0bde01f19be7@gmx.com>

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

On Mon, 2017-10-30 at 07:59 +0800, Qu Wenruo wrote:
> 
> On 2017年10月30日 01:15, Ben Hutchings wrote:
> > You recently made a number of fixes to validation and use of name
> > lengths in btrfs:
> > 
> > 286b92f43c0d btrfs: tree-log.c: Wrong printk information about namelen
> > 19c6dcbfa746 btrfs: Introduce btrfs_is_name_len_valid to avoid reading beyond boundary
> > e79a33270d05 btrfs: Check name_len with boundary in verify dir_item
> > 26a836cec2ea btrfs: Check name_len on add_inode_ref call path
> > 8ee8c2d62d5f btrfs: Verify dir_item in replay_xattr_deletes
> > 3c1d41844896 btrfs: Check name_len in btrfs_check_ref_name_override
> > 59b0a7f2c7c1 btrfs: Check name_len before read in iterate_dir_item
> > 488d7c456653 btrfs: Check name_len before reading btrfs_get_name
> > 64c7b01446f4 btrfs: Check name_len before in btrfs_del_root_ref
> > fbc326159a01 btrfs: Verify dir_item in iterate_object_props
> > 
> > The bugs these are fixing probably should also be fixed on the affected
> > stable branches.  Do you agree?  Can you provide any guidance about how
> > far back these fixes would be needed?
> 
> These fixes will soon be replace by centralized tree-checker facilities.

Is that likely to be a small enough change to be reasonably backport-
able?

Ben.

-- 
Ben Hutchings
friends: People who know you well, but like you anyway.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-10-30  0:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-29 17:15 [stable] btrfs name length fixes Ben Hutchings
2017-10-29 23:59 ` Qu Wenruo
2017-10-30  0:19   ` Ben Hutchings [this message]
2017-10-30  0:45     ` Qu Wenruo
2017-10-30  1:46       ` Ben Hutchings
2017-10-30  1:55   ` Su Yue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509322782.2721.74.camel@decadent.org.uk \
    --to=ben@decadent.org.uk \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=stable@vger.kernel.org \
    --cc=suy.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox