From: Ben Hutchings <ben@decadent.org.uk>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, Su Yue <suy.fnst@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [stable] btrfs name length fixes
Date: Mon, 30 Oct 2017 01:46:41 +0000 [thread overview]
Message-ID: <1509328001.2721.78.camel@decadent.org.uk> (raw)
In-Reply-To: <837a9f6f-adb3-bf63-09db-9f3eb368fca8@gmx.com>
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]
On Mon, 2017-10-30 at 08:45 +0800, Qu Wenruo wrote:
>
> On 2017年10月30日 08:19, Ben Hutchings wrote:
> > On Mon, 2017-10-30 at 07:59 +0800, Qu Wenruo wrote:
[...]
> > > These fixes will soon be replace by centralized tree-checker facilities.
> >
> > Is that likely to be a small enough change to be reasonably backport-
> > able?
>
> It depends.
>
> Check the thread with the subject "[PATCH v3 0/5] Enhance tree block
> validation checker"
>
> ----
> fs/btrfs/Makefile | 2 +-
> fs/btrfs/ctree.h | 4 +
> fs/btrfs/disk-io.c | 284 +-------------------------------
> fs/btrfs/tree-checker.c | 429
> ++++++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 437 insertions(+), 282 deletions(-)
> create mode 100644 fs/btrfs/tree-checker.c
> ----
That looks like it would be too big for stable.
> Since it's centralized, most of the modification will be in
> tree-checker.c, and make the impact to existing code to minimal.
>
> However that patchset is just the skeleton of the whole thing, name_len
> related code is not moved to tree-checker yet.
>
>
> On the other hand, the whole name_len patchset is just an enhanced
> validation checker, I'm not pretty sure if such thing should be back
> ported especially when it's just a whack-a-hole solution.
I see. Thanks for the information.
Ben.
--
Ben Hutchings
friends: People who know you well, but like you anyway.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-30 1:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 17:15 [stable] btrfs name length fixes Ben Hutchings
2017-10-29 23:59 ` Qu Wenruo
2017-10-30 0:19 ` Ben Hutchings
2017-10-30 0:45 ` Qu Wenruo
2017-10-30 1:46 ` Ben Hutchings [this message]
2017-10-30 1:55 ` Su Yue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509328001.2721.78.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=stable@vger.kernel.org \
--cc=suy.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox