From: Doug Ledford <dledford@redhat.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org, Daniel Jurgens <danielj@mellanox.com>,
stable@vger.kernel.org
Subject: Re: [PATCH rdma-next] IB/core: Only maintain real QPs in the security lists
Date: Mon, 13 Nov 2017 16:24:55 -0500 [thread overview]
Message-ID: <1510608295.3735.41.camel@redhat.com> (raw)
In-Reply-To: <20171107163326.23881-1-leon@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]
On Tue, 2017-11-07 at 18:33 +0200, Leon Romanovsky wrote:
> From: Daniel Jurgens <danielj@mellanox.com>
>
> When modify QP is called on a shared QP update the security context for
> the real QP. When security is subsequently enforced the shared QP
> handles will be checked as well.
>
> Without this change shared QP handles get added to the port/pkey lists,
> which is a bug, because not all shared QP handles will be checked for
> access. Also the shared QP security context wouldn't get removed from
> the port/pkey lists causing access to free memory and list corruption
> when they are destroyed.
>
> Cc: stable@vger.kernel.org
> Fixes: d291f1a65232 ("IB/core: Enforce PKey security on QPs")
> Signed-off-by: Daniel Jurgens <danielj@mellanox.com>
> Reviewed-by: Parav Pandit <parav@mellanox.com>
> Signed-off-by: Leon Romanovsky <leon@kernel.org>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-11-13 21:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 16:33 [PATCH rdma-next] IB/core: Only maintain real QPs in the security lists Leon Romanovsky
2017-11-07 16:46 ` Jason Gunthorpe
2017-11-07 16:52 ` Daniel Jurgens
2017-11-07 16:55 ` Jason Gunthorpe
2017-11-07 17:10 ` Leon Romanovsky
2017-11-07 17:31 ` Jason Gunthorpe
2017-11-07 17:15 ` Daniel Jurgens
2017-11-07 17:32 ` Jason Gunthorpe
2017-11-07 18:40 ` Leon Romanovsky
2017-11-13 21:24 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510608295.3735.41.camel@redhat.com \
--to=dledford@redhat.com \
--cc=danielj@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox