From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, Daniel Jurgens <danielj@mellanox.com>,
stable@vger.kernel.org
Subject: Re: [PATCH rdma-next] IB/core: Only maintain real QPs in the security lists
Date: Tue, 7 Nov 2017 09:46:32 -0700 [thread overview]
Message-ID: <20171107164632.GA7063@ziepe.ca> (raw)
In-Reply-To: <20171107163326.23881-1-leon@kernel.org>
On Tue, Nov 07, 2017 at 06:33:26PM +0200, Leon Romanovsky wrote:
> - bool special_qp = (qp->qp_type == IB_QPT_SMI ||
> - qp->qp_type == IB_QPT_GSI ||
> - qp->qp_type >= IB_QPT_RESERVED1);
> + struct ib_qp *real_qp = qp->real_qp;
> + bool special_qp = (real_qp->qp_type == IB_QPT_SMI ||
> + real_qp->qp_type == IB_QPT_GSI ||
> + real_qp->qp_type >= IB_QPT_RESERVED1);
This QPT_RESERVED stuff was not supposed to be visible to the core
layer, so why are we adding checks in security????
Jason
next prev parent reply other threads:[~2017-11-07 16:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 16:33 [PATCH rdma-next] IB/core: Only maintain real QPs in the security lists Leon Romanovsky
2017-11-07 16:46 ` Jason Gunthorpe [this message]
2017-11-07 16:52 ` Daniel Jurgens
2017-11-07 16:55 ` Jason Gunthorpe
2017-11-07 17:10 ` Leon Romanovsky
2017-11-07 17:31 ` Jason Gunthorpe
2017-11-07 17:15 ` Daniel Jurgens
2017-11-07 17:32 ` Jason Gunthorpe
2017-11-07 18:40 ` Leon Romanovsky
2017-11-13 21:24 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107164632.GA7063@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=danielj@mellanox.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox