FAILED: patch "[PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on" failed to apply to 4.14-stable tree

FAILED: patch "[PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on" failed to apply to 4.14-stable tree

[gregkh]

The patch below does not apply to the 4.14-stable tree.
If someone wants it applied there, or to any other stable or longterm
tree, then please email the backport, including the original git commit
id to <stable@vger.kernel.org>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From a8772e5d826d0f61f8aa9c284b3ab49035d5273d Mon Sep 17 00:00:00 2001
From: Tomohiro Mayama <parly-gh@iris.mystia.org>
Date: Sun, 10 Mar 2019 01:10:12 +0900
Subject: [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on
 rk3328-rock64

This patch makes USB ports functioning again.

Fixes: 955bebde057e ("arm64: dts: rockchip: add rk3328-rock64 board")
Cc: stable@vger.kernel.org
Suggested-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Tomohiro Mayama <parly-gh@iris.mystia.org>
Tested-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index 2157a528276b..79b4d1d4b5d6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -46,8 +46,7 @@
 
 	vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
 		compatible = "regulator-fixed";
-		enable-active-high;
-		gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&usb20_host_drv>;
 		regulator-name = "vcc_host1_5v";

Re: FAILED: patch "[PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on" failed to apply to 4.14-stable tree

[Robin Murphy]

On 15/04/2019 16:56, gregkh@linuxfoundation.org wrote:
> 
> The patch below does not apply to the 4.14-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git commit
> id to <stable@vger.kernel.org>.

Ah, I guess this depends on ef05bcb60c1a ("arm64: dts: rockchip: fix 
vcc_host1_5v pin assign on rk3328-rock64"), which doesn't look to have 
been tagged for stable.

Robin.

> 
> thanks,
> 
> greg k-h
> 
> ------------------ original commit in Linus's tree ------------------
> 
>  From a8772e5d826d0f61f8aa9c284b3ab49035d5273d Mon Sep 17 00:00:00 2001
> From: Tomohiro Mayama <parly-gh@iris.mystia.org>
> Date: Sun, 10 Mar 2019 01:10:12 +0900
> Subject: [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on
>   rk3328-rock64
> 
> This patch makes USB ports functioning again.
> 
> Fixes: 955bebde057e ("arm64: dts: rockchip: add rk3328-rock64 board")
> Cc: stable@vger.kernel.org
> Suggested-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Tomohiro Mayama <parly-gh@iris.mystia.org>
> Tested-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> index 2157a528276b..79b4d1d4b5d6 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> @@ -46,8 +46,7 @@
>   
>   	vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
>   		compatible = "regulator-fixed";
> -		enable-active-high;
> -		gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
> +		gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&usb20_host_drv>;
>   		regulator-name = "vcc_host1_5v";
> 

Re: FAILED: patch "[PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on" failed to apply to 4.14-stable tree

[Greg KH]

On Mon, Apr 15, 2019 at 05:47:25PM +0100, Robin Murphy wrote:
> On 15/04/2019 16:56, gregkh@linuxfoundation.org wrote:
> > 
> > The patch below does not apply to the 4.14-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> 
> Ah, I guess this depends on ef05bcb60c1a ("arm64: dts: rockchip: fix
> vcc_host1_5v pin assign on rk3328-rock64"), which doesn't look to have been
> tagged for stable.

That worked, thanks!

greg k-h