Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
To: <akpm@linux-foundation.org>
Cc: <mm-commits@vger.kernel.org>, <stable@vger.kernel.org>,
	<matthias.bgg@gmail.com>, <glider@google.com>,
	<dvyukov@google.com>, <aryabinin@virtuozzo.com>,
	<miles.chen@mediatek.com>
Subject: Re: [to-be-updated] kasan-fix-memory-leak-of-kasan-quarantine.patch removed from -mm tree
Date: Thu, 24 Dec 2020 19:52:04 +0800	[thread overview]
Message-ID: <1608810724.9171.65.camel@mtksdccf07> (raw)
In-Reply-To: <20201222190426.zM-LA%akpm@linux-foundation.org>

On Tue, 2020-12-22 at 11:04 -0800, akpm@linux-foundation.org wrote:
> The patch titled
>      Subject: kasan: fix memory leak of kasan quarantine
> has been removed from the -mm tree.  Its filename was
>      kasan-fix-memory-leak-of-kasan-quarantine.patch
> 
> This patch was dropped because an updated version will be merged
> 
> ------------------------------------------------------
> From: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
> Subject: kasan: fix memory leak of kasan quarantine
> 
> When cpu is going offline, set q->offline as true and interrupt happened. 
> The interrupt may call the quarantine_put.  But quarantine_put do not free
> the the object.  The object will cause memory leak.
> 
> Add qlink_free() to free the object.
> 
> Link: https://lkml.kernel.org/r/1608207487-30537-2-git-send-email-Kuan-Ying.Lee@mediatek.com
> Fixes: 6c82d45c7f03 (kasan: fix object remaining in offline per-cpu quarantine)
> Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Cc: Alexander Potapenko <glider@google.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: <stable@vger.kernel.org>    [5.10-]
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  mm/kasan/quarantine.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/mm/kasan/quarantine.c~kasan-fix-memory-leak-of-kasan-quarantine
> +++ a/mm/kasan/quarantine.c
> @@ -194,6 +194,7 @@ bool quarantine_put(struct kmem_cache *c
>  
>  	q = this_cpu_ptr(&cpu_quarantine);
>  	if (q->offline) {
> +		qlink_free(&info->quarantine_link, cache);
>  		local_irq_restore(flags);
>  		return false;
>  	}
> _
> 
> Patches currently in -mm which might be from Kuan-Ying.Lee@mediatek.com are
> 
> 

Hi Andrew,

Sorry to bother.
After recently kasan series merged into mainline, the memory leak
issue has been fixed. We don't need this patch anymore.

This patch state can be changed to obsolete.

Please abandon this patch.

Thanks.


      reply	other threads:[~2020-12-24 11:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22 19:04 [to-be-updated] kasan-fix-memory-leak-of-kasan-quarantine.patch removed from -mm tree akpm
2020-12-24 11:52 ` Kuan-Ying Lee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1608810724.9171.65.camel@mtksdccf07 \
    --to=kuan-ying.lee@mediatek.com \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=matthias.bgg@gmail.com \
    --cc=miles.chen@mediatek.com \
    --cc=mm-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox