* [to-be-updated] kasan-fix-memory-leak-of-kasan-quarantine.patch removed from -mm tree
@ 2020-12-22 19:04 akpm
2020-12-24 11:52 ` Kuan-Ying Lee
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2020-12-22 19:04 UTC (permalink / raw)
To: mm-commits, stable, matthias.bgg, glider, dvyukov, aryabinin,
Kuan-Ying.Lee
The patch titled
Subject: kasan: fix memory leak of kasan quarantine
has been removed from the -mm tree. Its filename was
kasan-fix-memory-leak-of-kasan-quarantine.patch
This patch was dropped because an updated version will be merged
------------------------------------------------------
From: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Subject: kasan: fix memory leak of kasan quarantine
When cpu is going offline, set q->offline as true and interrupt happened.
The interrupt may call the quarantine_put. But quarantine_put do not free
the the object. The object will cause memory leak.
Add qlink_free() to free the object.
Link: https://lkml.kernel.org/r/1608207487-30537-2-git-send-email-Kuan-Ying.Lee@mediatek.com
Fixes: 6c82d45c7f03 (kasan: fix object remaining in offline per-cpu quarantine)
Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: <stable@vger.kernel.org> [5.10-]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/kasan/quarantine.c | 1 +
1 file changed, 1 insertion(+)
--- a/mm/kasan/quarantine.c~kasan-fix-memory-leak-of-kasan-quarantine
+++ a/mm/kasan/quarantine.c
@@ -194,6 +194,7 @@ bool quarantine_put(struct kmem_cache *c
q = this_cpu_ptr(&cpu_quarantine);
if (q->offline) {
+ qlink_free(&info->quarantine_link, cache);
local_irq_restore(flags);
return false;
}
_
Patches currently in -mm which might be from Kuan-Ying.Lee@mediatek.com are
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [to-be-updated] kasan-fix-memory-leak-of-kasan-quarantine.patch removed from -mm tree
2020-12-22 19:04 [to-be-updated] kasan-fix-memory-leak-of-kasan-quarantine.patch removed from -mm tree akpm
@ 2020-12-24 11:52 ` Kuan-Ying Lee
0 siblings, 0 replies; 2+ messages in thread
From: Kuan-Ying Lee @ 2020-12-24 11:52 UTC (permalink / raw)
To: akpm
Cc: mm-commits, stable, matthias.bgg, glider, dvyukov, aryabinin,
miles.chen
On Tue, 2020-12-22 at 11:04 -0800, akpm@linux-foundation.org wrote:
> The patch titled
> Subject: kasan: fix memory leak of kasan quarantine
> has been removed from the -mm tree. Its filename was
> kasan-fix-memory-leak-of-kasan-quarantine.patch
>
> This patch was dropped because an updated version will be merged
>
> ------------------------------------------------------
> From: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
> Subject: kasan: fix memory leak of kasan quarantine
>
> When cpu is going offline, set q->offline as true and interrupt happened.
> The interrupt may call the quarantine_put. But quarantine_put do not free
> the the object. The object will cause memory leak.
>
> Add qlink_free() to free the object.
>
> Link: https://lkml.kernel.org/r/1608207487-30537-2-git-send-email-Kuan-Ying.Lee@mediatek.com
> Fixes: 6c82d45c7f03 (kasan: fix object remaining in offline per-cpu quarantine)
> Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Cc: Alexander Potapenko <glider@google.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: <stable@vger.kernel.org> [5.10-]
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> mm/kasan/quarantine.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/mm/kasan/quarantine.c~kasan-fix-memory-leak-of-kasan-quarantine
> +++ a/mm/kasan/quarantine.c
> @@ -194,6 +194,7 @@ bool quarantine_put(struct kmem_cache *c
>
> q = this_cpu_ptr(&cpu_quarantine);
> if (q->offline) {
> + qlink_free(&info->quarantine_link, cache);
> local_irq_restore(flags);
> return false;
> }
> _
>
> Patches currently in -mm which might be from Kuan-Ying.Lee@mediatek.com are
>
>
Hi Andrew,
Sorry to bother.
After recently kasan series merged into mainline, the memory leak
issue has been fixed. We don't need this patch anymore.
This patch state can be changed to obsolete.
Please abandon this patch.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-24 11:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-22 19:04 [to-be-updated] kasan-fix-memory-leak-of-kasan-quarantine.patch removed from -mm tree akpm
2020-12-24 11:52 ` Kuan-Ying Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox