Re: [PATCH] thermal: exynos: Propagate error value from tmu_read()

[Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>]

On Tuesday, February 27, 2018 04:14:05 PM Marek Szyprowski wrote:
> tmu_read() in case of Exynos4210 might return error for out of bound
> values. Current code ignores such value, what leads to reporting critical
> temperature value. Add proper error code propagation to exynos_get_temp()
> function.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> CC: stable@vger.kernel.org # v4.6+

Thanks for fixing this.

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

> ---
> This patch is prepared on top of "thermal: exynos: Reading temperature
> makes sense only when TMU is turned on" patch. Both are required
> to finally fix thermal support on Exynos4210 based boards.
> 
> This patch only applies cleanly together with the mentioned "thermal:
> exynos: Reading temperature makes sense only when TMU is turned on"
> patch on v4.6+ kernels.

You may also add:

Fixes: 3b6a1a805f34 ("thermal: samsung: core: Exynos TMU rework to use device tree for configuration")

to the patch description.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics