From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Andy Shevchenko <andy@kernel.org>, Hans de Goede <hdegoede@redhat.com>
Cc: James Harmison <jharmison@redhat.com>,
platform-driver-x86@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/3] platform/x86: panasonic-laptop: Fix SINF array out of bounds accesses
Date: Mon, 09 Sep 2024 20:54:40 +0300 [thread overview]
Message-ID: <172590448046.2114.11735502570640542626.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20240909113227.254470-1-hdegoede@redhat.com>
On Mon, 09 Sep 2024 13:32:25 +0200, Hans de Goede wrote:
> The panasonic laptop code in various places uses the SINF array with index
> values of 0 - SINF_CUR_BRIGHT(0x0d) without checking that the SINF array
> is big enough.
>
> Not all panasonic laptops have this many SINF array entries, for example
> the Toughbook CF-18 model only has 10 SINF array entries. So it only
> supports the AC+DC brightness entries and mute.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/3] platform/x86: panasonic-laptop: Fix SINF array out of bounds accesses
commit: f52e98d16e9bd7dd2b3aef8e38db5cbc9899d6a4
[2/3] platform/x86: panasonic-laptop: Allocate 1 entry extra in the sinf array
commit: 33297cef3101d950cec0033a0dce0a2d2bd59999
[3/3] platform/x86: panasonic-laptop: Add support for programmable buttons
(no commit info)
--
i.
next prev parent reply other threads:[~2024-09-09 17:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 11:32 [PATCH v2 1/3] platform/x86: panasonic-laptop: Fix SINF array out of bounds accesses Hans de Goede
2024-09-09 11:32 ` [PATCH v2 2/3] platform/x86: panasonic-laptop: Allocate 1 entry extra in the sinf array Hans de Goede
2024-09-09 12:06 ` [PATCH v2 1/3] platform/x86: panasonic-laptop: Fix SINF array out of bounds accesses Andy Shevchenko
2024-09-09 12:11 ` Hans de Goede
2024-09-09 12:46 ` Andy Shevchenko
2024-09-09 17:54 ` Ilpo Järvinen [this message]
2024-09-09 18:40 ` Ilpo Järvinen
2024-09-10 14:26 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172590448046.2114.11735502570640542626.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=jharmison@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox