Re: [PATCH v2 1/3] platform/x86: panasonic-laptop: Fix SINF array out of bounds accesses

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

On Mon, 9 Sep 2024, Ilpo Järvinen wrote:

> On Mon, 09 Sep 2024 13:32:25 +0200, Hans de Goede wrote:
> 
> > The panasonic laptop code in various places uses the SINF array with index
> > values of 0 - SINF_CUR_BRIGHT(0x0d) without checking that the SINF array
> > is big enough.
> > 
> > Not all panasonic laptops have this many SINF array entries, for example
> > the Toughbook CF-18 model only has 10 SINF array entries. So it only
> > supports the AC+DC brightness entries and mute.
> > 
> > [...]
> 
> 
> Thank you for your contribution, it has been applied to my local
> review-ilpo branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo branch only once I've pushed my
> local branch there, which might take a while.
> 
> The list of commits applied:
> [1/3] platform/x86: panasonic-laptop: Fix SINF array out of bounds accesses
>       commit: f52e98d16e9bd7dd2b3aef8e38db5cbc9899d6a4
> [2/3] platform/x86: panasonic-laptop: Allocate 1 entry extra in the sinf array
>       commit: 33297cef3101d950cec0033a0dce0a2d2bd59999
> [3/3] platform/x86: panasonic-laptop: Add support for programmable buttons
>       (no commit info)

Hmpf, b4 messed this one up. Only patches 1-2 were applied and 3 should 
go through for-next.

-- 
 i.