Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ij@kernel.org>
To: Sasha Levin <sashal@kernel.org>,
	 Chia-Yu Chang <chia-yu.chang@nokia-bell-labs.com>
Cc: Eric Dumazet <edumazet@google.com>,
	stable@vger.kernel.org,  stable-commits@vger.kernel.org,
	Neal Cardwell <ncardwell@google.com>,
	 "David S. Miller" <davem@davemloft.net>,
	David Ahern <dsahern@kernel.org>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,  Simon Horman <horms@kernel.org>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	 Willem de Bruijn <willemb@google.com>
Subject: Re: Patch "tcp: reorganize tcp_in_ack_event() and tcp_count_delivered()" has been added to the 6.6-stable tree
Date: Fri, 13 Jun 2025 00:17:25 +0300 (EEST)	[thread overview]
Message-ID: <175e6075-a930-196d-37ce-7f2815141d07@kernel.org> (raw)
In-Reply-To: <aEspV8Ttk7uBM4Gx@lappy>

[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]

+ Chia-Yu


On Thu, 12 Jun 2025, Sasha Levin wrote:
> On Thu, Jun 12, 2025 at 01:40:57AM -0700, Eric Dumazet wrote:
> > On Thu, May 22, 2025 at 3:44 PM Sasha Levin <sashal@kernel.org> wrote:
> > > 
> > > This is a note to let you know that I've just added the patch titled
> > > 
> > >     tcp: reorganize tcp_in_ack_event() and tcp_count_delivered()
> > > 
> > > to the 6.6-stable tree which can be found at:
> > >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > > 
> > > The filename of the patch is:
> > >      tcp-reorganize-tcp_in_ack_event-and-tcp_count_delive.patch
> > > and it can be found in the queue-6.6 subdirectory.
> > > 
> > > If you, or anyone else, feels it should not be added to the stable tree,
> > > please let <stable@vger.kernel.org> know about it.
> > > 
> > > 
> > 
> > May I ask why this patch was backported to stable versions  ?

As you see Eric, you got no answer to a very direct question.

I've long since stopped caring unless a change really looks dangerous 
(this one didn't) what they take into stable, especially since they tend
to ignore on-what-grounds questions.

> > This is causing a packetdrill test to fail.
> 
> Is this an issue upstream as well? Should we just drop it from stable?

It's long since I've done anything with packetdrill so it will take some 
time for me to test. Maybe Chia-Yu can check this faster (but I assume 
it's also problem in mainline as this is reported by Eric).

-- 
 i.

  reply	other threads:[~2025-06-12 21:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250522224433.3219290-1-sashal@kernel.org>
2025-06-12  8:40 ` Patch "tcp: reorganize tcp_in_ack_event() and tcp_count_delivered()" has been added to the 6.6-stable tree Eric Dumazet
2025-06-12 19:24   ` Sasha Levin
2025-06-12 21:17     ` Ilpo Järvinen [this message]
2025-06-14 13:55       ` Chia-Yu Chang (Nokia)
2025-06-17 13:53         ` Greg KH
2025-06-17 14:40         ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175e6075-a930-196d-37ce-7f2815141d07@kernel.org \
    --to=ij@kernel.org \
    --cc=chia-yu.chang@nokia-bell-labs.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=ncardwell@google.com \
    --cc=pabeni@redhat.com \
    --cc=sashal@kernel.org \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox