From: patchwork-bot+netdevbpf@kernel.org
To: Breno Leitao <leitao@debian.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, ushankar@purestorage.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
clm@meta.com, kernel-team@meta.com, stable@vger.kernel.org
Subject: Re: [PATCH net] netpoll: pass buffer size to egress_dev() to avoid MAC truncation
Date: Tue, 05 May 2026 02:00:08 +0000 [thread overview]
Message-ID: <177794640854.1386640.5844242432544883755.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260501-netpoll_snprintf_fix-v1-1-84b0566e6597@debian.org>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 01 May 2026 02:58:41 -0700 you wrote:
> egress_dev() formats np->dev_mac via snprintf() but receives buf as
> a bare char *, so it cannot derive the buffer size from the pointer. The
> size argument was hardcoded to MAC_ADDR_STR_LEN (3 * ETH_ALEN - 1 = 17),
> which is silly wrong in two ways:
>
> 1) misleading kernel log output on the MAC-selected target path
> (np->dev_name[0] == '\0'); for example "aa:bb:cc:dd:ee:ff doesn't
> exist, aborting" was logged as "aa:bb:cc:dd:ee:f doesn't exist,
> aborting".
>
> [...]
Here is the summary with links:
- [net] netpoll: pass buffer size to egress_dev() to avoid MAC truncation
https://git.kernel.org/netdev/net/c/76b93a810757
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-05-05 2:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 9:58 [PATCH net] netpoll: pass buffer size to egress_dev() to avoid MAC truncation Breno Leitao
2026-05-05 2:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177794640854.1386640.5844242432544883755.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=clm@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox