From: Abdifatah Suruur <suruurism@gmail.com>
To: stable@vger.kernel.org
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
Greg KH <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH 6.12.y 0/2] nft_byteorder: fix the uninitialised-stack read without removing multi-register support
Date: Mon, 09 Nov 2026 15:22:49 +0300 [thread overview]
Message-ID: <179422696909.5131.4005481731765358036@gmail.com> (raw)
Pablo pointed out that the full upstream removal (bb061d3) cannot be
applied to stable trees: nftables versions before 1.1.0 can generate
len != size byteorder expressions, and the removal rejects them, so
existing rulesets may fail to load. The removal is tagged
stable+noautosel for that reason.
This series restores the multi-register path in 6.12.y and fixes the
uninitialised-stack read with a targeted initialisation:
1/2 reverts the removal currently in 6.12.y.
2/2 zeroes the destination span marked initialised by the control
plane, but only when source and destination registers differ, so
in-place conversions (sreg == dreg) keep their value.
This does not reject any rule and keeps the old userspace-visible
behaviour. It removes the dependency on CONFIG_INIT_STACK_ALL_ZERO
zeroing the register file.
Compile-tested by reverting the removal and applying 2/2 to the
pre-removal tree; runtime testing on 6.12.y is welcome.
Abdifatah Suruur (2):
Revert "netfilter: nft_byteorder: remove multi-register support"
netfilter: nft_byteorder: initialise the marked destination span
Pablo, this is the stable-specific alternative we discussed. If a single
folded patch is preferred, I can resend it that way.
next reply other threads:[~2026-11-09 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 12:22 Abdifatah Suruur [this message]
2026-11-09 12:22 ` [PATCH 6.12.y 1/2] Revert "netfilter: nft_byteorder: remove multi-register support" Abdifatah Suruur
2026-11-09 12:25 ` Pablo Neira Ayuso
2026-11-09 12:34 ` Pablo Neira Ayuso
2026-11-09 12:48 ` Sasha Levin
2026-11-09 13:18 ` Abdifatah Suruur
2026-11-09 12:22 ` [PATCH 6.12.y 2/2] netfilter: nft_byteorder: initialise the marked destination span Abdifatah Suruur
2026-11-09 12:27 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179422696909.5131.4005481731765358036@gmail.com \
--to=suruurism@gmail.com \
--cc=fw@strlen.de \
--cc=gregkh@linuxfoundation.org \
--cc=pablo@netfilter.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox