* add 3acca1dd to 4.19-stable
@ 2019-04-26 10:55 Rasmus Villemoes
2019-04-26 18:57 ` Heiner Kallweit
0 siblings, 1 reply; 3+ messages in thread
From: Rasmus Villemoes @ 2019-04-26 10:55 UTC (permalink / raw)
To: stable@vger.kernel.org; +Cc: Heiner Kallweit, Andrew Lunn, Greg Kroah-Hartman
After ed8fe20205ac (net: dsa: mv88e6xxx: prevent interrupt storm caused
by mv88e6390x_port_set_cmode) got into 4.19-stable (as 4d8f5df0), a
non-CONFIG_NET_DSA_LEGACY build warns
drivers/net/dsa/mv88e6xxx/chip.c:4635:13: warning:
‘mv88e6xxx_ports_cmode_init’ defined but not used [-Wunused-function]
I think 3acca1dd (net: dsa: mv88e6xxx: add call to
mv88e6xxx_ports_cmode_init to probe for new DSA framework) should be
added to the same stable trees that ed8fe20205ac was, at least 4.19.
Thanks,
Rasmus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: add 3acca1dd to 4.19-stable
2019-04-26 10:55 add 3acca1dd to 4.19-stable Rasmus Villemoes
@ 2019-04-26 18:57 ` Heiner Kallweit
2019-04-27 14:00 ` Sasha Levin
0 siblings, 1 reply; 3+ messages in thread
From: Heiner Kallweit @ 2019-04-26 18:57 UTC (permalink / raw)
To: Rasmus Villemoes, stable@vger.kernel.org, David Miller
Cc: Andrew Lunn, Greg Kroah-Hartman
On 26.04.2019 12:55, Rasmus Villemoes wrote:
> After ed8fe20205ac (net: dsa: mv88e6xxx: prevent interrupt storm caused
> by mv88e6390x_port_set_cmode) got into 4.19-stable (as 4d8f5df0), a
> non-CONFIG_NET_DSA_LEGACY build warns
>
> drivers/net/dsa/mv88e6xxx/chip.c:4635:13: warning:
> ‘mv88e6xxx_ports_cmode_init’ defined but not used [-Wunused-function]
>
> I think 3acca1dd (net: dsa: mv88e6xxx: add call to
> mv88e6xxx_ports_cmode_init to probe for new DSA framework) should be
> added to the same stable trees that ed8fe20205ac was, at least 4.19.
>
That's right. Actually the referenced fix should have been applied to
4.19, not sure why this wasn't done. On 5.0 it was applied.
That's the confirmation from Dave that it was queued up for stable.
https://marc.info/?l=linux-netdev&m=155173359712109&w=2
> Thanks,
> Rasmus
>
Heiner
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: add 3acca1dd to 4.19-stable
2019-04-26 18:57 ` Heiner Kallweit
@ 2019-04-27 14:00 ` Sasha Levin
0 siblings, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2019-04-27 14:00 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Rasmus Villemoes, stable@vger.kernel.org, David Miller,
Andrew Lunn, Greg Kroah-Hartman
On Fri, Apr 26, 2019 at 08:57:51PM +0200, Heiner Kallweit wrote:
>On 26.04.2019 12:55, Rasmus Villemoes wrote:
>> After ed8fe20205ac (net: dsa: mv88e6xxx: prevent interrupt storm caused
>> by mv88e6390x_port_set_cmode) got into 4.19-stable (as 4d8f5df0), a
>> non-CONFIG_NET_DSA_LEGACY build warns
>>
>> drivers/net/dsa/mv88e6xxx/chip.c:4635:13: warning:
>> ‘mv88e6xxx_ports_cmode_init’ defined but not used [-Wunused-function]
>>
>> I think 3acca1dd (net: dsa: mv88e6xxx: add call to
>> mv88e6xxx_ports_cmode_init to probe for new DSA framework) should be
>> added to the same stable trees that ed8fe20205ac was, at least 4.19.
>>
>That's right. Actually the referenced fix should have been applied to
>4.19, not sure why this wasn't done. On 5.0 it was applied.
>
>That's the confirmation from Dave that it was queued up for stable.
>https://marc.info/?l=linux-netdev&m=155173359712109&w=2
I've queued it for 4.19, thanks!
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-27 14:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-26 10:55 add 3acca1dd to 4.19-stable Rasmus Villemoes
2019-04-26 18:57 ` Heiner Kallweit
2019-04-27 14:00 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox