Re: Question: drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback()

Re: Question: drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback()

[Johan Hovold]

Hi Sasha, 

On Wed, Apr 08, 2015 at 05:29:16PM +0000, Mark Enstone wrote:
> Everyone, thank you for your attention and suggestions.
> 
> Johan, perfect, thank you, that did indeed help and has fixed the
> issue I was seeing.
> 
> The change replaced dev_err() with dev_dbg() -- thus not logging (by
> default) what was a very noisy flood of messages. Does that simply
> change timing enough such that the USB HCD has time to process the
> disconnect? Or is there something else going on that I'm missing?

> > -----Original Message-----
> > From: Johan Hovold [mailto:jhovold@gmail.com] On Behalf Of Johan Hovold
> > Sent: Tuesday, April 07, 2015 2:58 PM
> > To: Mark Enstone
> > Cc: linux-usb@vger.kernel.org
> > Subject: Re: Question: drivers/usb/serial/generic.c:
> > usb_serial_generic_read_bulk_callback()

> > Could you try updating to 3.19 (or later) or to cherry pick aa8e22128b40
> > ("usb: serial: silence all non-critical read errors") and see if that helps?
> > 
> > We should backport that one to stable either way.

You may want to add aa8e22128b40 ("usb: serial: silence all non-critical
read errors") to 3.18-stable as it fixes a lock-up-on-disconnect
regression with at least two controllers (3.15 through 3.18 are
affected).

Thanks,
Johan

Re: Question: drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback()

[Sasha Levin]

On 04/27/2015 05:44 AM, Johan Hovold wrote:
>>> Could you try updating to 3.19 (or later) or to cherry pick aa8e22128b40
>>> > > ("usb: serial: silence all non-critical read errors") and see if that helps?
>>> > > 
>>> > > We should backport that one to stable either way.
> You may want to add aa8e22128b40 ("usb: serial: silence all non-critical
> read errors") to 3.18-stable as it fixes a lock-up-on-disconnect
> regression with at least two controllers (3.15 through 3.18 are
> affected).

I've added it to the queue, thanks!


Thanks,
Sasha

Re: Question: drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback()

[Luis Henriques]

On Mon, Apr 27, 2015 at 11:44:58AM +0200, Johan Hovold wrote:
> Hi Sasha, 
> 
> On Wed, Apr 08, 2015 at 05:29:16PM +0000, Mark Enstone wrote:
> > Everyone, thank you for your attention and suggestions.
> > 
> > Johan, perfect, thank you, that did indeed help and has fixed the
> > issue I was seeing.
> > 
> > The change replaced dev_err() with dev_dbg() -- thus not logging (by
> > default) what was a very noisy flood of messages. Does that simply
> > change timing enough such that the USB HCD has time to process the
> > disconnect? Or is there something else going on that I'm missing?
> 
> > > -----Original Message-----
> > > From: Johan Hovold [mailto:jhovold@gmail.com] On Behalf Of Johan Hovold
> > > Sent: Tuesday, April 07, 2015 2:58 PM
> > > To: Mark Enstone
> > > Cc: linux-usb@vger.kernel.org
> > > Subject: Re: Question: drivers/usb/serial/generic.c:
> > > usb_serial_generic_read_bulk_callback()
> 
> > > Could you try updating to 3.19 (or later) or to cherry pick aa8e22128b40
> > > ("usb: serial: silence all non-critical read errors") and see if that helps?
> > > 
> > > We should backport that one to stable either way.
> 
> You may want to add aa8e22128b40 ("usb: serial: silence all non-critical
> read errors") to 3.18-stable as it fixes a lock-up-on-disconnect
> regression with at least two controllers (3.15 through 3.18 are
> affected).
> 

Thanks, I'm also queuing this patch to the 3.16 kernel.

Cheers,
--
Lu�s

> Thanks,
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html