stable fix for IOSF in Kconfig

stable fix for IOSF in Kconfig

[William Dauchy]

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

Hello,

Using a stable 3.14.x kernel, I had an issue where I was unable to set
IOSF_MBI as builtin.

I applied the following commit on top of my 3.14.x:

commit aa8e4f22ab7773352ba3895597189b8097f2c307
Author: David E. Box <david.e.box@linux.intel.com>
Date:   Wed Aug 27 14:40:39 2014 -0700
x86/iosf: Add Kconfig prompt for IOSF_MBI selection

This fixes my issue.
Do you think it's a good candidate for stable branches?


we may also consider the following commit for stable:
commit ced3ce760b8df08e8bafba44f6b40407df2d0402
Author: David E. Box <david.e.box@linux.intel.com>
Date:   Wed Sep 17 22:13:50 2014 -0700
x86/platform/intel/iosf: Add better description of IOSF driver in config


Regards,
-- 
William

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: stable fix for IOSF in Kconfig

[Greg KH]

On Wed, May 20, 2015 at 02:27:47PM +0200, William Dauchy wrote:
> Hello,
> 
> Using a stable 3.14.x kernel, I had an issue where I was unable to set
> IOSF_MBI as builtin.
> 
> I applied the following commit on top of my 3.14.x:
> 
> commit aa8e4f22ab7773352ba3895597189b8097f2c307
> Author: David E. Box <david.e.box@linux.intel.com>
> Date:   Wed Aug 27 14:40:39 2014 -0700
> x86/iosf: Add Kconfig prompt for IOSF_MBI selection
> 
> This fixes my issue.
> Do you think it's a good candidate for stable branches?

Yes, that makes sense, I'll queue it up soon.

> we may also consider the following commit for stable:
> commit ced3ce760b8df08e8bafba44f6b40407df2d0402
> Author: David E. Box <david.e.box@linux.intel.com>
> Date:   Wed Sep 17 22:13:50 2014 -0700
> x86/platform/intel/iosf: Add better description of IOSF driver in config

Does this fix a problem?  I don't mind it, but is it really needed?

thanks,

greg k-h

Re: stable fix for IOSF in Kconfig

[William Dauchy]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

Hi Greg,

Thanks for your reply.

On May20 08:59, Greg KH wrote:
> > we may also consider the following commit for stable:
> > commit ced3ce760b8df08e8bafba44f6b40407df2d0402
> > Author: David E. Box <david.e.box@linux.intel.com>
> > Date:   Wed Sep 17 22:13:50 2014 -0700
> > x86/platform/intel/iosf: Add better description of IOSF driver in config
> 
> Does this fix a problem?  I don't mind it, but is it really needed?

as you may have seen in full commit message, it's just an improvement of the
previous commit, but it does not change anything for my particular issue
at the end; I was just suggesting (i.e not showing the entry in the main
menu)

Best regards,

-- 
William

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: stable fix for IOSF in Kconfig

[Greg KH]

On Wed, May 20, 2015 at 06:04:35PM +0200, William Dauchy wrote:
> Hi Greg,
> 
> Thanks for your reply.
> 
> On May20 08:59, Greg KH wrote:
> > > we may also consider the following commit for stable:
> > > commit ced3ce760b8df08e8bafba44f6b40407df2d0402
> > > Author: David E. Box <david.e.box@linux.intel.com>
> > > Date:   Wed Sep 17 22:13:50 2014 -0700
> > > x86/platform/intel/iosf: Add better description of IOSF driver in config
> > 
> > Does this fix a problem?  I don't mind it, but is it really needed?
> 
> as you may have seen in full commit message, it's just an improvement of the
> previous commit, but it does not change anything for my particular issue
> at the end; I was just suggesting (i.e not showing the entry in the main
> menu)

As it doesn't fix a real bug, I'll not apply it, thanks.

See Documentation/stable_kernel_rules.txt for the details as to what
makes up a valid stable kernel patch.

greg k-h

Re: stable fix for IOSF in Kconfig

[William Dauchy]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

On Jun29 15:53, Greg KH wrote:
> As it doesn't fix a real bug, I'll not apply it, thanks.

agreed; but the first one is targeted for future stables releases,
right?

Thanks,
-- 
William

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: stable fix for IOSF in Kconfig

[Greg KH]

On Thu, Jul 02, 2015 at 11:24:10AM +0200, William Dauchy wrote:
> On Jun29 15:53, Greg KH wrote:
> > As it doesn't fix a real bug, I'll not apply it, thanks.
> 
> agreed; but the first one is targeted for future stables releases,
> right?

The first "what"?  There is no context here :(

Re: stable fix for IOSF in Kconfig

[William Dauchy]

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

On Jul02 06:07, Greg KH wrote:
> On Thu, Jul 02, 2015 at 11:24:10AM +0200, William Dauchy wrote:
> > On Jun29 15:53, Greg KH wrote:
> > > As it doesn't fix a real bug, I'll not apply it, thanks.
> > 
> > agreed; but the first one is targeted for future stables releases,
> > right?
> 
> The first "what"?  There is no context here :(

sorry: http://www.spinics.net/lists/stable/msg91732.html
"Yes, that makes sense, I'll queue it up soon." Wed, 20 May 2015
but since then I did not saw it yet.

> commit aa8e4f22ab7773352ba3895597189b8097f2c307
> Author: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
> Date:   Wed Aug 27 14:40:39 2014 -0700
> x86/iosf: Add Kconfig prompt for IOSF_MBI selection

Regards,
-- 
William

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: stable fix for IOSF in Kconfig

[Greg KH]

On Thu, Jul 02, 2015 at 03:19:15PM +0200, William Dauchy wrote:
> On Jul02 06:07, Greg KH wrote:
> > On Thu, Jul 02, 2015 at 11:24:10AM +0200, William Dauchy wrote:
> > > On Jun29 15:53, Greg KH wrote:
> > > > As it doesn't fix a real bug, I'll not apply it, thanks.
> > > 
> > > agreed; but the first one is targeted for future stables releases,
> > > right?
> > 
> > The first "what"?  There is no context here :(
> 
> sorry: http://www.spinics.net/lists/stable/msg91732.html
> "Yes, that makes sense, I'll queue it up soon." Wed, 20 May 2015
> but since then I did not saw it yet.
> 
> > commit aa8e4f22ab7773352ba3895597189b8097f2c307
> > Author: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
> > Date:   Wed Aug 27 14:40:39 2014 -0700
> > x86/iosf: Add Kconfig prompt for IOSF_MBI selection

Ah, missed that somehow, sorry, now queued up.

greg k-h

Re: stable fix for IOSF in Kconfig

[Luis Henriques]

On Wed, May 20, 2015 at 02:27:47PM +0200, William Dauchy wrote:
> Hello,
> 
> Using a stable 3.14.x kernel, I had an issue where I was unable to set
> IOSF_MBI as builtin.
> 
> I applied the following commit on top of my 3.14.x:
> 
> commit aa8e4f22ab7773352ba3895597189b8097f2c307
> Author: David E. Box <david.e.box@linux.intel.com>
> Date:   Wed Aug 27 14:40:39 2014 -0700
> x86/iosf: Add Kconfig prompt for IOSF_MBI selection
>

Thanks, I'm queuing this commit for the 3.16 kernel as well.

Cheers,
--
Lu�s


> This fixes my issue.
> Do you think it's a good candidate for stable branches?
> 
> 
> we may also consider the following commit for stable:
> commit ced3ce760b8df08e8bafba44f6b40407df2d0402
> Author: David E. Box <david.e.box@linux.intel.com>
> Date:   Wed Sep 17 22:13:50 2014 -0700
> x86/platform/intel/iosf: Add better description of IOSF driver in config
> 
> 
> Regards,
> -- 
> William