* [PATCH 3/4] drm/dp-mst: Remove debug WARN_ON [not found] <1438615451-856-1-git-send-email-daniel.vetter@ffwll.ch> @ 2015-08-03 15:24 ` Daniel Vetter 2015-08-04 8:53 ` Thierry Reding 0 siblings, 1 reply; 2+ messages in thread From: Daniel Vetter @ 2015-08-03 15:24 UTC (permalink / raw) To: DRI Development, Intel Graphics Development Cc: Daniel Vetter, Dave Airlie, stable, Daniel Vetter Apparently been in there since forever and fairly easy to hit when hotplugging really fast. I can do that since my mst hub has a manual button to flick the hpd line for reprobing. The resulting WARNING spam isn't pretty. Cc: Dave Airlie <airlied@gmail.com> Cc: stable@vger.kernel.org Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 778bbb6425b8..b0487c9f018c 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -1294,7 +1294,6 @@ retry: goto retry; } DRM_DEBUG_KMS("failed to dpcd write %d %d\n", tosend, ret); - WARN(1, "fail\n"); return -EIO; } -- 2.5.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/4] drm/dp-mst: Remove debug WARN_ON 2015-08-03 15:24 ` [PATCH 3/4] drm/dp-mst: Remove debug WARN_ON Daniel Vetter @ 2015-08-04 8:53 ` Thierry Reding 0 siblings, 0 replies; 2+ messages in thread From: Thierry Reding @ 2015-08-04 8:53 UTC (permalink / raw) To: Daniel Vetter Cc: DRI Development, Intel Graphics Development, stable, Daniel Vetter [-- Attachment #1: Type: text/plain, Size: 991 bytes --] On Mon, Aug 03, 2015 at 05:24:10PM +0200, Daniel Vetter wrote: > Apparently been in there since forever and fairly easy to hit when > hotplugging really fast. I can do that since my mst hub has a manual > button to flick the hpd line for reprobing. The resulting WARNING spam > isn't pretty. > > Cc: Dave Airlie <airlied@gmail.com> > Cc: stable@vger.kernel.org > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index 778bbb6425b8..b0487c9f018c 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -1294,7 +1294,6 @@ retry: > goto retry; > } > DRM_DEBUG_KMS("failed to dpcd write %d %d\n", tosend, ret); > - WARN(1, "fail\n"); > > return -EIO; > } Reviewed-by: Thierry Reding <treding@nvidia.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-04 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1438615451-856-1-git-send-email-daniel.vetter@ffwll.ch>
2015-08-03 15:24 ` [PATCH 3/4] drm/dp-mst: Remove debug WARN_ON Daniel Vetter
2015-08-04 8:53 ` Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox