* [PATCH] ARM: nomadik: set latencies to 8 cycles
@ 2016-01-04 1:18 Linus Walleij
2016-01-07 5:30 ` Olof Johansson
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2016-01-04 1:18 UTC (permalink / raw)
To: arm; +Cc: linux-arm-kernel, Linus Walleij, stable
The Nomadik has sporadic crashes because of these latencies, setting
them to max makes the platform work nicely, so use this values for
now.
These latencies were set to 2 since the Nomadik platform was merged,
but I suspect they never took effect until the right size and
associativity for the cache was specified in the device tree and
that is why the crash comes now.
Cc: stable@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ARM SoC folks: please apply this directly for fixes at your
convenience.
---
arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
index 314f59c12162..d0c743853318 100644
--- a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
+++ b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
@@ -25,9 +25,9 @@
cache-sets = <512>;
cache-line-size = <32>;
/* At full speed latency must be >=2 */
- arm,tag-latency = <2>;
- arm,data-latency = <2 2>;
- arm,dirty-latency = <2>;
+ arm,tag-latency = <8>;
+ arm,data-latency = <8 8>;
+ arm,dirty-latency = <8>;
};
mtu0: mtu@101e2000 {
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ARM: nomadik: set latencies to 8 cycles
2016-01-04 1:18 [PATCH] ARM: nomadik: set latencies to 8 cycles Linus Walleij
@ 2016-01-07 5:30 ` Olof Johansson
0 siblings, 0 replies; 2+ messages in thread
From: Olof Johansson @ 2016-01-07 5:30 UTC (permalink / raw)
To: Linus Walleij; +Cc: arm, linux-arm-kernel, stable
On Mon, Jan 04, 2016 at 02:18:28AM +0100, Linus Walleij wrote:
> The Nomadik has sporadic crashes because of these latencies, setting
> them to max makes the platform work nicely, so use this values for
> now.
>
> These latencies were set to 2 since the Nomadik platform was merged,
> but I suspect they never took effect until the right size and
> associativity for the cache was specified in the device tree and
> that is why the crash comes now.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ARM SoC folks: please apply this directly for fixes at your
> convenience.
Applied to fixes. THanks.
-Olof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-07 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-04 1:18 [PATCH] ARM: nomadik: set latencies to 8 cycles Linus Walleij
2016-01-07 5:30 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox