From: Jean Delvare <jdelvare@suse.de>
To: "Michał Kępień" <kernel@kempniu.pl>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] dell-wmi: Stop storing pointers to DMI tables
Date: Fri, 15 Jan 2016 14:23:19 +0100 [thread overview]
Message-ID: <20160115142319.51f79994@endymion.delvare> (raw)
In-Reply-To: <20160114095204.GA5473@eudyptula.hq.kempniu.pl>
On Thu, 14 Jan 2016 10:52:04 +0100, Michał Kępień wrote:
> > > Hi Andy, I looked at this patch, but I think some people from -mm or DMI
> > > code should look at it as it is memory problem... We also has one in
> > > dell-laptop.ko (wrong API usage) and so -mm people could know it better.
>
> > There are at least two platform drivers (dell-wmi and dell-laptop)
> > that don't play well with the current interface. This patch is
> > intended to fix one of them.
>
> Pali, Andy,
>
> Could you point out the exact place where dell-laptop errs? AFAICT, it
> only has one use of dmi_walk(), the callback there calls
> parse_da_table(), which does the right thing, i.e. krealloc()'ing memory
> and then memcpy()'ing table contents there...
FWIW I can't see any problem with dell-laptop either.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-01-15 13:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-03 14:52 [PATCH] dell-wmi: Stop storing pointers to DMI tables Andy Lutomirski
2016-01-11 21:58 ` Andy Lutomirski
2016-01-12 14:25 ` Pali Rohár
2016-01-13 22:28 ` Andy Lutomirski
2016-01-14 9:52 ` Michał Kępień
2016-01-15 13:23 ` Jean Delvare [this message]
2016-01-15 13:27 ` Jean Delvare
2016-01-15 16:27 ` Andy Lutomirski
2016-01-15 17:53 ` Jean Delvare
2016-01-15 20:00 ` Andy Lutomirski
2016-01-14 10:29 ` Michał Kępień
2016-01-18 15:44 ` Jean Delvare
2016-01-18 18:09 ` Andy Lutomirski
2016-01-18 18:19 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115142319.51f79994@endymion.delvare \
--to=jdelvare@suse.de \
--cc=jdelvare@suse.com \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox