* [PATCH] ARM: imx6ul: Fix Micrel PHY mask
@ 2016-05-11 19:39 Fabio Estevam
2016-05-11 19:50 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2016-05-11 19:39 UTC (permalink / raw)
To: shawnguo; +Cc: fugang.duan, linux-arm-kernel, Fabio Estevam, stable
From: Fabio Estevam <fabio.estevam@nxp.com>
The value used for Micrel PHY mask is not correct. Use the
MICREL_PHY_ID_MASK definition instead.
Thanks to Jiri Luznicky for proposing the fix at
https://community.freescale.com/thread/387739
Cc: <stable@vger.kernel.org>
Fixes: 709bc0657fe6f9f55 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup init")
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/mach-imx/mach-imx6ul.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/mach-imx6ul.c b/arch/arm/mach-imx/mach-imx6ul.c
index a38b16b..b56de4b 100644
--- a/arch/arm/mach-imx/mach-imx6ul.c
+++ b/arch/arm/mach-imx/mach-imx6ul.c
@@ -46,7 +46,7 @@ static int ksz8081_phy_fixup(struct phy_device *dev)
static void __init imx6ul_enet_phy_init(void)
{
if (IS_BUILTIN(CONFIG_PHYLIB))
- phy_register_fixup_for_uid(PHY_ID_KSZ8081, 0xffffffff,
+ phy_register_fixup_for_uid(PHY_ID_KSZ8081, MICREL_PHY_ID_MASK,
ksz8081_phy_fixup);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: imx6ul: Fix Micrel PHY mask 2016-05-11 19:39 [PATCH] ARM: imx6ul: Fix Micrel PHY mask Fabio Estevam @ 2016-05-11 19:50 ` Andrew Lunn 2016-05-11 19:53 ` Fabio Estevam 0 siblings, 1 reply; 3+ messages in thread From: Andrew Lunn @ 2016-05-11 19:50 UTC (permalink / raw) To: Fabio Estevam Cc: shawnguo, Fabio Estevam, fugang.duan, stable, linux-arm-kernel On Wed, May 11, 2016 at 04:39:30PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@nxp.com> > > The value used for Micrel PHY mask is not correct. Use the > MICREL_PHY_ID_MASK definition instead. > > Thanks to Jiri Luznicky for proposing the fix at > https://community.freescale.com/thread/387739 > > Cc: <stable@vger.kernel.org> > Fixes: 709bc0657fe6f9f55 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup init") > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> It would be nice if drivers/net/phy/micrel.c was to use MICREL_PHY_ID_MASK. But that is a different patch. Thanks Andrew ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: imx6ul: Fix Micrel PHY mask 2016-05-11 19:50 ` Andrew Lunn @ 2016-05-11 19:53 ` Fabio Estevam 0 siblings, 0 replies; 3+ messages in thread From: Fabio Estevam @ 2016-05-11 19:53 UTC (permalink / raw) To: Andrew Lunn Cc: Shawn Guo, Fabio Estevam, Fugang Duan, stable, linux-arm-kernel@lists.infradead.org On Wed, May 11, 2016 at 4:50 PM, Andrew Lunn <andrew@lunn.ch> wrote: > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > It would be nice if drivers/net/phy/micrel.c was to use > MICREL_PHY_ID_MASK. But that is a different patch. Good suggestion. I will submit a patch doing this. Thanks ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-11 19:53 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-05-11 19:39 [PATCH] ARM: imx6ul: Fix Micrel PHY mask Fabio Estevam 2016-05-11 19:50 ` Andrew Lunn 2016-05-11 19:53 ` Fabio Estevam
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox