Re: [PATCH 3.14.y 3/9] cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind

[Greg KH <greg@kroah.com>]

On Sun, Aug 14, 2016 at 04:52:55PM +0200, Bj�rn Mork wrote:
> Greg KH <greg@kroah.com> writes:
> > On Mon, Jul 18, 2016 at 04:53:17PM -0400, Charles (Chas) Williams wrote:
> >> From: Bj�rn Mork <bjorn@mork.no>
> >> 
> >> commit 4d06dd537f95683aba3651098ae288b7cbff8274 upstream.
> >> 
> >> usbnet_link_change will call schedule_work and should be
> >> avoided if bind is failing. Otherwise we will end up with
> >> scheduled work referring to a netdev which has gone away.
> >> 
> >> Instead of making the call conditional, we can just defer
> >> it to usbnet_probe, using the driver_info flag made for
> >> this purpose.
> >> 
> >> CVE-2016-3951
> >> 
> >> Fixes: 8a34b0ae8778 ("usbnet: cdc_ncm: apply usbnet_link_change")
> >> Reported-by: Andrey Konovalov <andreyknvl@gmail.com>
> >> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> >> Signed-off-by: Bj�rn Mork <bjorn@mork.no>
> >> Signed-off-by: David S. Miller <davem@davemloft.net>
> >> [ciwillia@brocade.com: backported to 3.14: adjusted context]
> >> Signed-off-by: Charles (Chas) Williams <ciwillia@brocade.com>
> >> ---
> >>  drivers/net/usb/cdc_ncm.c | 20 +++++---------------
> >>  1 file changed, 5 insertions(+), 15 deletions(-)
> >
> > Another patch that isn't in 4.4-stable, why not?
> 
> Probably because I was sloppy when first posting it, and forgot to ask
> David to queue it for stable.  I see that this has later been requested
> by  Chas Williams:
> https://www.mail-archive.com/netdev@vger.kernel.org/msg120134.html 
> 
> Yes, it should go into 4.4-stable.

Thanks for letting me know, now queued up.

greg k-h