From: Michal Kubecek <mkubecek@suse.cz>
To: Greg KH <greg@kroah.com>
Cc: "Charles (Chas) Williams" <ciwillia@brocade.com>,
stable@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Luis Henriques <luis.henriques@canonical.com>
Subject: Re: [PATCH 3.14.y 1/9] udp: properly support MSG_PEEK with truncated buffers
Date: Mon, 15 Aug 2016 09:21:02 +0200 [thread overview]
Message-ID: <20160815072102.GA6529@unicorn.suse.cz> (raw)
In-Reply-To: <20160814144209.GA27230@kroah.com>
On Sun, Aug 14, 2016 at 04:42:09PM +0200, Greg KH wrote:
> On Mon, Jul 18, 2016 at 04:53:15PM -0400, Charles (Chas) Williams wrote:
> > From: Eric Dumazet <edumazet@google.com>
> >
> > commit 197c949e7798fbf28cfadc69d9ca0c2abbf93191 upstream.
>
> Why isn't this in 4.4-stable? I can't take it into 3.14-stable unless I
> also have it in 4.4, otherwise it would be a regression when people
> upgraded, right?
>
> And if this isn't in 4.4-stable, why not? I'm guessing that the authors
> didn't think it was necessary...
As the commit message says:
This bug does not happen in upstream kernels since Al Viro did a great
job to replace this into :
skb_copy_and_csum_datagram_msg(skb, sizeof(struct udphdr), msg);
This variant is safe vs short buffers.
That happened in 3.19 by commit 227158db1604 ("new helper:
skb_copy_and_csum_datagram_msg()"). The mainline commit is useful as it
prevents calculating the checksum twice but it's not really stable
material; on the other hand, it addresses a serious issue in stable
kernels 3.18 and older (those with backport of commit 89c22d8c3b27).
Michal Kubecek
prev parent reply other threads:[~2016-08-15 7:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 20:53 [PATCH 3.14.y 1/9] udp: properly support MSG_PEEK with truncated buffers Charles (Chas) Williams
2016-07-18 20:53 ` [PATCH 3.14.y 2/9] USB: fix invalid memory access in hub_activate() Charles (Chas) Williams
2016-07-18 20:53 ` [PATCH 3.14.y 3/9] cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind Charles (Chas) Williams
2016-08-14 14:43 ` Greg KH
2016-08-14 14:52 ` Bjørn Mork
2016-08-14 15:05 ` Greg KH
2016-07-18 20:53 ` [PATCH 3.14.y 4/9] KEYS: potential uninitialized variable Charles (Chas) Williams
2016-07-18 20:53 ` [PATCH 3.14.y 5/9] USB: usbfs: fix potential infoleak in devio Charles (Chas) Williams
2016-08-14 14:44 ` Greg Kroah-Hartman
2016-08-15 14:41 ` Charles (Chas) Williams
2016-07-18 20:58 ` [PATCH 3.14.y 6/9] mm: migrate dirty page without clear_page_dirty_for_io etc Charles (Chas) Williams
2016-07-18 20:59 ` [PATCH 3.14.y 7/9] printk: do cond_resched() between lines while outputting to consoles Charles (Chas) Williams
2016-07-18 20:59 ` [PATCH 3.14.y 8/9] HID: hiddev: validate num_values for HIDIOCGUSAGES, HIDIOCSUSAGES commands Charles (Chas) Williams
2016-07-18 20:59 ` [PATCH 3.14.y 9/9] x86/mm: Add barriers and document switch_mm()-vs-flush synchronization Charles (Chas) Williams
2016-08-14 14:42 ` [PATCH 3.14.y 1/9] udp: properly support MSG_PEEK with truncated buffers Greg KH
2016-08-15 7:21 ` Michal Kubecek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815072102.GA6529@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=ciwillia@brocade.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=greg@kroah.com \
--cc=luis.henriques@canonical.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox