From: Daniel Vetter <daniel@ffwll.ch>
To: Daniel Stone <daniels@collabora.com>
Cc: intel-gfx@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>,
ville.syrjala@intel.com, stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm: i915: Wait for fences on new fb, not old
Date: Mon, 24 Oct 2016 09:03:16 +0200 [thread overview]
Message-ID: <20161024070316.GA20761@phenom.ffwll.local> (raw)
In-Reply-To: <20161021144454.6288-1-daniels@collabora.com>
On Fri, Oct 21, 2016 at 03:44:54PM +0100, Daniel Stone wrote:
> The previous code would wait for fences on the framebuffer from the old
> plane state to complete, rather than the new, so you would see tearing
> everywhere. Fix this to wait on the new state before we make it active.
>
> Signed-off-by: Daniel Stone <daniels@collabora.com>
> Fixes: 94f050246b42 ("drm/i915: nonblocking commit")
> Cc: stable@vger.kernel.org
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index e5ad101..1bdef9e 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -14292,7 +14292,7 @@ static void intel_atomic_commit_tail(struct drm_atomic_state *state)
>
> for_each_plane_in_state(state, plane, plane_state, i) {
> struct intel_plane_state *intel_plane_state =
> - to_intel_plane_state(plane_state);
> + to_intel_plane_state(plane->state);
>
> if (!intel_plane_state->wait_req)
> continue;
> --
> 2.9.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2016-10-24 7:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 14:44 [PATCH] drm: i915: Wait for fences on new fb, not old Daniel Stone
2016-10-24 7:03 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024070316.GA20761@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=daniels@collabora.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox