* [PATCH v2 1/1] usb: chipidea: move the lock initialization to core file @ 2016-11-15 6:02 Peter Chen 2016-11-15 6:58 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Peter Chen @ 2016-11-15 6:02 UTC (permalink / raw) To: gregkh; +Cc: linux-usb, Peter Chen, #v4 . 1+ This can fix below dump when the lock is accessed at host mode due to it is not initialized. [ 46.119638] INFO: trying to register non-static key. [ 46.124643] the code is fine but needs lockdep annotation. [ 46.130144] turning off the locking correctness validator. [ 46.135659] CPU: 0 PID: 690 Comm: cat Not tainted 4.9.0-rc3-00079-g4b75f1d #1210 [ 46.143075] Hardware name: Freescale i.MX6 SoloX (Device Tree) [ 46.148923] Backtrace: [ 46.151448] [<c010c460>] (dump_backtrace) from [<c010c658>] (show_stack+0x18/0x1c) [ 46.159038] r7:edf52000 [ 46.161412] r6:60000193 [ 46.163967] r5:00000000 [ 46.165035] r4:c0e25c2c [ 46.169109] [<c010c640>] (show_stack) from [<c03f58a4>] (dump_stack+0xb4/0xe8) [ 46.176362] [<c03f57f0>] (dump_stack) from [<c016d690>] (register_lock_class+0x4fc/0x56c) [ 46.184554] r10:c0e25d24 [ 46.187014] r9:edf53e70 [ 46.189569] r8:c1642444 [ 46.190637] r7:ee9da024 [ 46.193191] r6:00000000 [ 46.194258] r5:00000000 [ 46.196812] r4:00000000 [ 46.199185] r3:00000001 [ 46.203259] [<c016d194>] (register_lock_class) from [<c0171294>] (__lock_acquire+0x80/0x10f0) [ 46.211797] r10:c0e25d24 [ 46.214257] r9:edf53e70 [ 46.216813] r8:ee9da024 [ 46.217880] r7:c1642444 [ 46.220435] r6:edcd1800 [ 46.221502] r5:60000193 [ 46.224057] r4:00000000 [ 46.227953] [<c0171214>] (__lock_acquire) from [<c01726c0>] (lock_acquire+0x74/0x94) [ 46.235710] r10:00000001 [ 46.238169] r9:edf53e70 [ 46.240723] r8:edf53f80 [ 46.241790] r7:00000001 [ 46.244344] r6:00000001 [ 46.245412] r5:60000193 [ 46.247966] r4:00000000 [ 46.251866] [<c017264c>] (lock_acquire) from [<c096c8fc>] (_raw_spin_lock_irqsave+0x40/0x54) [ 46.260319] r7:ee1c6a00 [ 46.262691] r6:c062a570 [ 46.265247] r5:20000113 [ 46.266314] r4:ee9da014 [ 46.270393] [<c096c8bc>] (_raw_spin_lock_irqsave) from [<c062a570>] (ci_port_test_show+0x2c/0x70) [ 46.279280] r6:eebd2000 [ 46.281652] r5:ee9da010 [ 46.284207] r4:ee9da014 [ 46.286810] [<c062a544>] (ci_port_test_show) from [<c0248d04>] (seq_read+0x1ac/0x4f8) [ 46.294655] r9:edf53e70 [ 46.297028] r8:edf53f80 [ 46.299583] r7:ee1c6a00 [ 46.300650] r6:00000001 [ 46.303205] r5:00000000 [ 46.304273] r4:eebd2000 [ 46.306850] [<c0248b58>] (seq_read) from [<c039e864>] (full_proxy_read+0x54/0x6c) [ 46.314348] r10:00000000 [ 46.316808] r9:c0a6ad30 [ 46.319363] r8:edf53f80 [ 46.320430] r7:00020000 [ 46.322986] r6:b6de3000 [ 46.324053] r5:ee1c6a00 [ 46.326607] r4:c0248b58 [ 46.330505] [<c039e810>] (full_proxy_read) from [<c021ec98>] (__vfs_read+0x34/0x118) [ 46.338262] r9:edf52000 [ 46.340635] r8:c0107fc4 [ 46.343190] r7:00020000 [ 46.344257] r6:edf53f80 [ 46.346812] r5:c039e810 [ 46.347879] r4:ee1c6a00 [ 46.350447] [<c021ec64>] (__vfs_read) from [<c021fbd0>] (vfs_read+0x8c/0x11c) [ 46.357597] r9:edf52000 [ 46.359969] r8:c0107fc4 [ 46.362524] r7:edf53f80 [ 46.363592] r6:b6de3000 [ 46.366147] r5:ee1c6a00 [ 46.367214] r4:00020000 [ 46.369782] [<c021fb44>] (vfs_read) from [<c0220a4c>] (SyS_read+0x4c/0xa8) [ 46.376672] r8:c0107fc4 [ 46.379045] r7:00020000 [ 46.381600] r6:b6de3000 [ 46.382667] r5:ee1c6a00 [ 46.385222] r4:ee1c6a00 [ 46.387817] [<c0220a00>] (SyS_read) from [<c0107e20>] (ret_fast_syscall+0x0/0x1c) [ 46.395314] r7:00000003 [ 46.397687] r6:b6de3000 [ 46.400243] r5:00020000 [ 46.401310] r4:00020000 Cc: <stable@vger.kernel.org> #v4.1+ Signed-off-by: Peter Chen <peter.chen@nxp.com> --- Changes for v2: - Clean up dump message by using dmesg output instead of console output. drivers/usb/chipidea/core.c | 1 + drivers/usb/chipidea/udc.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index a7d2c68..c5e7f3d 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c @@ -873,6 +873,7 @@ static int ci_hdrc_probe(struct platform_device *pdev) if (!ci) return -ENOMEM; + spin_lock_init(&ci->lock); ci->dev = dev; ci->platdata = dev_get_platdata(dev); ci->imx28_write_fix = !!(ci->platdata->flags & diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 1e0ffad..e7bd064 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -1886,8 +1886,6 @@ static int udc_start(struct ci_hdrc *ci) struct usb_otg_caps *otg_caps = &ci->platdata->ci_otg_caps; int retval = 0; - spin_lock_init(&ci->lock); - ci->gadget.ops = &usb_gadget_ops; ci->gadget.speed = USB_SPEED_UNKNOWN; ci->gadget.max_speed = USB_SPEED_HIGH; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] usb: chipidea: move the lock initialization to core file 2016-11-15 6:02 [PATCH v2 1/1] usb: chipidea: move the lock initialization to core file Peter Chen @ 2016-11-15 6:58 ` Greg KH 2016-11-15 7:15 ` Peter Chen 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2016-11-15 6:58 UTC (permalink / raw) To: Peter Chen; +Cc: linux-usb, #v4 . 1+ On Tue, Nov 15, 2016 at 02:02:47PM +0800, Peter Chen wrote: > This can fix below dump when the lock is accessed at host > mode due to it is not initialized. > > [ 46.119638] INFO: trying to register non-static key. > [ 46.124643] the code is fine but needs lockdep annotation. > [ 46.130144] turning off the locking correctness validator. > [ 46.135659] CPU: 0 PID: 690 Comm: cat Not tainted 4.9.0-rc3-00079-g4b75f1d #1210 > [ 46.143075] Hardware name: Freescale i.MX6 SoloX (Device Tree) > [ 46.148923] Backtrace: > [ 46.151448] [<c010c460>] (dump_backtrace) from [<c010c658>] (show_stack+0x18/0x1c) > [ 46.159038] r7:edf52000 > [ 46.161412] r6:60000193 > [ 46.163967] r5:00000000 > [ 46.165035] r4:c0e25c2c > > [ 46.169109] [<c010c640>] (show_stack) from [<c03f58a4>] (dump_stack+0xb4/0xe8) > [ 46.176362] [<c03f57f0>] (dump_stack) from [<c016d690>] (register_lock_class+0x4fc/0x56c) > [ 46.184554] r10:c0e25d24 > [ 46.187014] r9:edf53e70 > [ 46.189569] r8:c1642444 > [ 46.190637] r7:ee9da024 > [ 46.193191] r6:00000000 > [ 46.194258] r5:00000000 > [ 46.196812] r4:00000000 > [ 46.199185] r3:00000001 > > [ 46.203259] [<c016d194>] (register_lock_class) from [<c0171294>] (__lock_acquire+0x80/0x10f0) > [ 46.211797] r10:c0e25d24 > [ 46.214257] r9:edf53e70 > [ 46.216813] r8:ee9da024 > [ 46.217880] r7:c1642444 > [ 46.220435] r6:edcd1800 > [ 46.221502] r5:60000193 > [ 46.224057] r4:00000000 > > [ 46.227953] [<c0171214>] (__lock_acquire) from [<c01726c0>] (lock_acquire+0x74/0x94) > [ 46.235710] r10:00000001 > [ 46.238169] r9:edf53e70 > [ 46.240723] r8:edf53f80 > [ 46.241790] r7:00000001 > [ 46.244344] r6:00000001 > [ 46.245412] r5:60000193 > [ 46.247966] r4:00000000 > > [ 46.251866] [<c017264c>] (lock_acquire) from [<c096c8fc>] (_raw_spin_lock_irqsave+0x40/0x54) > [ 46.260319] r7:ee1c6a00 > [ 46.262691] r6:c062a570 > [ 46.265247] r5:20000113 > [ 46.266314] r4:ee9da014 > > [ 46.270393] [<c096c8bc>] (_raw_spin_lock_irqsave) from [<c062a570>] (ci_port_test_show+0x2c/0x70) > [ 46.279280] r6:eebd2000 > [ 46.281652] r5:ee9da010 > [ 46.284207] r4:ee9da014 > > [ 46.286810] [<c062a544>] (ci_port_test_show) from [<c0248d04>] (seq_read+0x1ac/0x4f8) > [ 46.294655] r9:edf53e70 > [ 46.297028] r8:edf53f80 > [ 46.299583] r7:ee1c6a00 > [ 46.300650] r6:00000001 > [ 46.303205] r5:00000000 > [ 46.304273] r4:eebd2000 > [ 46.306850] [<c0248b58>] (seq_read) from [<c039e864>] (full_proxy_read+0x54/0x6c) > [ 46.314348] r10:00000000 > [ 46.316808] r9:c0a6ad30 > [ 46.319363] r8:edf53f80 > [ 46.320430] r7:00020000 > [ 46.322986] r6:b6de3000 > [ 46.324053] r5:ee1c6a00 > [ 46.326607] r4:c0248b58 > > [ 46.330505] [<c039e810>] (full_proxy_read) from [<c021ec98>] (__vfs_read+0x34/0x118) > [ 46.338262] r9:edf52000 > [ 46.340635] r8:c0107fc4 > [ 46.343190] r7:00020000 > [ 46.344257] r6:edf53f80 > [ 46.346812] r5:c039e810 > [ 46.347879] r4:ee1c6a00 > [ 46.350447] [<c021ec64>] (__vfs_read) from [<c021fbd0>] (vfs_read+0x8c/0x11c) > [ 46.357597] r9:edf52000 > [ 46.359969] r8:c0107fc4 > [ 46.362524] r7:edf53f80 > [ 46.363592] r6:b6de3000 > [ 46.366147] r5:ee1c6a00 > [ 46.367214] r4:00020000 > [ 46.369782] [<c021fb44>] (vfs_read) from [<c0220a4c>] (SyS_read+0x4c/0xa8) > [ 46.376672] r8:c0107fc4 > [ 46.379045] r7:00020000 > [ 46.381600] r6:b6de3000 > [ 46.382667] r5:ee1c6a00 > [ 46.385222] r4:ee1c6a00 > > [ 46.387817] [<c0220a00>] (SyS_read) from [<c0107e20>] (ret_fast_syscall+0x0/0x1c) > [ 46.395314] r7:00000003 > [ 46.397687] r6:b6de3000 > [ 46.400243] r5:00020000 > [ 46.401310] r4:00020000 > > Cc: <stable@vger.kernel.org> #v4.1+ Any idea what commit caused the problem? thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] usb: chipidea: move the lock initialization to core file 2016-11-15 6:58 ` Greg KH @ 2016-11-15 7:15 ` Peter Chen 2016-11-15 9:32 ` Felipe Balbi 0 siblings, 1 reply; 6+ messages in thread From: Peter Chen @ 2016-11-15 7:15 UTC (permalink / raw) To: Greg KH; +Cc: Peter Chen, linux-usb, #v4 . 1+ On Tue, Nov 15, 2016 at 07:58:16AM +0100, Greg KH wrote: > On Tue, Nov 15, 2016 at 02:02:47PM +0800, Peter Chen wrote: > > This can fix below dump when the lock is accessed at host > > mode due to it is not initialized. > > > > [ 46.119638] INFO: trying to register non-static key. > > [ 46.124643] the code is fine but needs lockdep annotation. > > [ 46.130144] turning off the locking correctness validator. > > [ 46.135659] CPU: 0 PID: 690 Comm: cat Not tainted 4.9.0-rc3-00079-g4b75f1d #1210 > > [ 46.143075] Hardware name: Freescale i.MX6 SoloX (Device Tree) > > [ 46.148923] Backtrace: > > [ 46.151448] [<c010c460>] (dump_backtrace) from [<c010c658>] (show_stack+0x18/0x1c) > > [ 46.159038] r7:edf52000 > > [ 46.161412] r6:60000193 > > [ 46.163967] r5:00000000 > > [ 46.165035] r4:c0e25c2c > > > > [ 46.169109] [<c010c640>] (show_stack) from [<c03f58a4>] (dump_stack+0xb4/0xe8) > > [ 46.176362] [<c03f57f0>] (dump_stack) from [<c016d690>] (register_lock_class+0x4fc/0x56c) > > [ 46.184554] r10:c0e25d24 > > [ 46.187014] r9:edf53e70 > > [ 46.189569] r8:c1642444 > > [ 46.190637] r7:ee9da024 > > [ 46.193191] r6:00000000 > > [ 46.194258] r5:00000000 > > [ 46.196812] r4:00000000 > > [ 46.199185] r3:00000001 > > > > [ 46.203259] [<c016d194>] (register_lock_class) from [<c0171294>] (__lock_acquire+0x80/0x10f0) > > [ 46.211797] r10:c0e25d24 > > [ 46.214257] r9:edf53e70 > > [ 46.216813] r8:ee9da024 > > [ 46.217880] r7:c1642444 > > [ 46.220435] r6:edcd1800 > > [ 46.221502] r5:60000193 > > [ 46.224057] r4:00000000 > > > > [ 46.227953] [<c0171214>] (__lock_acquire) from [<c01726c0>] (lock_acquire+0x74/0x94) > > [ 46.235710] r10:00000001 > > [ 46.238169] r9:edf53e70 > > [ 46.240723] r8:edf53f80 > > [ 46.241790] r7:00000001 > > [ 46.244344] r6:00000001 > > [ 46.245412] r5:60000193 > > [ 46.247966] r4:00000000 > > > > [ 46.251866] [<c017264c>] (lock_acquire) from [<c096c8fc>] (_raw_spin_lock_irqsave+0x40/0x54) > > [ 46.260319] r7:ee1c6a00 > > [ 46.262691] r6:c062a570 > > [ 46.265247] r5:20000113 > > [ 46.266314] r4:ee9da014 > > > > [ 46.270393] [<c096c8bc>] (_raw_spin_lock_irqsave) from [<c062a570>] (ci_port_test_show+0x2c/0x70) > > [ 46.279280] r6:eebd2000 > > [ 46.281652] r5:ee9da010 > > [ 46.284207] r4:ee9da014 > > > > [ 46.286810] [<c062a544>] (ci_port_test_show) from [<c0248d04>] (seq_read+0x1ac/0x4f8) > > [ 46.294655] r9:edf53e70 > > [ 46.297028] r8:edf53f80 > > [ 46.299583] r7:ee1c6a00 > > [ 46.300650] r6:00000001 > > [ 46.303205] r5:00000000 > > [ 46.304273] r4:eebd2000 > > [ 46.306850] [<c0248b58>] (seq_read) from [<c039e864>] (full_proxy_read+0x54/0x6c) > > [ 46.314348] r10:00000000 > > [ 46.316808] r9:c0a6ad30 > > [ 46.319363] r8:edf53f80 > > [ 46.320430] r7:00020000 > > [ 46.322986] r6:b6de3000 > > [ 46.324053] r5:ee1c6a00 > > [ 46.326607] r4:c0248b58 > > > > [ 46.330505] [<c039e810>] (full_proxy_read) from [<c021ec98>] (__vfs_read+0x34/0x118) > > [ 46.338262] r9:edf52000 > > [ 46.340635] r8:c0107fc4 > > [ 46.343190] r7:00020000 > > [ 46.344257] r6:edf53f80 > > [ 46.346812] r5:c039e810 > > [ 46.347879] r4:ee1c6a00 > > [ 46.350447] [<c021ec64>] (__vfs_read) from [<c021fbd0>] (vfs_read+0x8c/0x11c) > > [ 46.357597] r9:edf52000 > > [ 46.359969] r8:c0107fc4 > > [ 46.362524] r7:edf53f80 > > [ 46.363592] r6:b6de3000 > > [ 46.366147] r5:ee1c6a00 > > [ 46.367214] r4:00020000 > > [ 46.369782] [<c021fb44>] (vfs_read) from [<c0220a4c>] (SyS_read+0x4c/0xa8) > > [ 46.376672] r8:c0107fc4 > > [ 46.379045] r7:00020000 > > [ 46.381600] r6:b6de3000 > > [ 46.382667] r5:ee1c6a00 > > [ 46.385222] r4:ee1c6a00 > > > > [ 46.387817] [<c0220a00>] (SyS_read) from [<c0107e20>] (ret_fast_syscall+0x0/0x1c) > > [ 46.395314] r7:00000003 > > [ 46.397687] r6:b6de3000 > > [ 46.400243] r5:00020000 > > [ 46.401310] r4:00020000 > > > > Cc: <stable@vger.kernel.org> #v4.1+ > > Any idea what commit caused the problem? > This issue has been existed from this driver has written, and the structure refined later, this patch can be applied after that (4 years ago), I think v4.1 is the last stable tree it can be applied. -- Best Regards, Peter Chen ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] usb: chipidea: move the lock initialization to core file 2016-11-15 7:15 ` Peter Chen @ 2016-11-15 9:32 ` Felipe Balbi 2016-11-15 9:56 ` Peter Chen 2016-11-15 10:05 ` Greg KH 0 siblings, 2 replies; 6+ messages in thread From: Felipe Balbi @ 2016-11-15 9:32 UTC (permalink / raw) To: Peter Chen, Greg KH; +Cc: Peter Chen, linux-usb, #v4 . 1+ [-- Attachment #1: Type: text/plain, Size: 4836 bytes --] Hi, Peter Chen <hzpeterchen@gmail.com> writes: > On Tue, Nov 15, 2016 at 07:58:16AM +0100, Greg KH wrote: >> On Tue, Nov 15, 2016 at 02:02:47PM +0800, Peter Chen wrote: >> > This can fix below dump when the lock is accessed at host >> > mode due to it is not initialized. >> > >> > [ 46.119638] INFO: trying to register non-static key. >> > [ 46.124643] the code is fine but needs lockdep annotation. >> > [ 46.130144] turning off the locking correctness validator. >> > [ 46.135659] CPU: 0 PID: 690 Comm: cat Not tainted 4.9.0-rc3-00079-g4b75f1d #1210 >> > [ 46.143075] Hardware name: Freescale i.MX6 SoloX (Device Tree) >> > [ 46.148923] Backtrace: >> > [ 46.151448] [<c010c460>] (dump_backtrace) from [<c010c658>] (show_stack+0x18/0x1c) >> > [ 46.159038] r7:edf52000 >> > [ 46.161412] r6:60000193 >> > [ 46.163967] r5:00000000 >> > [ 46.165035] r4:c0e25c2c >> > >> > [ 46.169109] [<c010c640>] (show_stack) from [<c03f58a4>] (dump_stack+0xb4/0xe8) >> > [ 46.176362] [<c03f57f0>] (dump_stack) from [<c016d690>] (register_lock_class+0x4fc/0x56c) >> > [ 46.184554] r10:c0e25d24 >> > [ 46.187014] r9:edf53e70 >> > [ 46.189569] r8:c1642444 >> > [ 46.190637] r7:ee9da024 >> > [ 46.193191] r6:00000000 >> > [ 46.194258] r5:00000000 >> > [ 46.196812] r4:00000000 >> > [ 46.199185] r3:00000001 >> > >> > [ 46.203259] [<c016d194>] (register_lock_class) from [<c0171294>] (__lock_acquire+0x80/0x10f0) >> > [ 46.211797] r10:c0e25d24 >> > [ 46.214257] r9:edf53e70 >> > [ 46.216813] r8:ee9da024 >> > [ 46.217880] r7:c1642444 >> > [ 46.220435] r6:edcd1800 >> > [ 46.221502] r5:60000193 >> > [ 46.224057] r4:00000000 >> > >> > [ 46.227953] [<c0171214>] (__lock_acquire) from [<c01726c0>] (lock_acquire+0x74/0x94) >> > [ 46.235710] r10:00000001 >> > [ 46.238169] r9:edf53e70 >> > [ 46.240723] r8:edf53f80 >> > [ 46.241790] r7:00000001 >> > [ 46.244344] r6:00000001 >> > [ 46.245412] r5:60000193 >> > [ 46.247966] r4:00000000 >> > >> > [ 46.251866] [<c017264c>] (lock_acquire) from [<c096c8fc>] (_raw_spin_lock_irqsave+0x40/0x54) >> > [ 46.260319] r7:ee1c6a00 >> > [ 46.262691] r6:c062a570 >> > [ 46.265247] r5:20000113 >> > [ 46.266314] r4:ee9da014 >> > >> > [ 46.270393] [<c096c8bc>] (_raw_spin_lock_irqsave) from [<c062a570>] (ci_port_test_show+0x2c/0x70) >> > [ 46.279280] r6:eebd2000 >> > [ 46.281652] r5:ee9da010 >> > [ 46.284207] r4:ee9da014 >> > >> > [ 46.286810] [<c062a544>] (ci_port_test_show) from [<c0248d04>] (seq_read+0x1ac/0x4f8) >> > [ 46.294655] r9:edf53e70 >> > [ 46.297028] r8:edf53f80 >> > [ 46.299583] r7:ee1c6a00 >> > [ 46.300650] r6:00000001 >> > [ 46.303205] r5:00000000 >> > [ 46.304273] r4:eebd2000 >> > [ 46.306850] [<c0248b58>] (seq_read) from [<c039e864>] (full_proxy_read+0x54/0x6c) >> > [ 46.314348] r10:00000000 >> > [ 46.316808] r9:c0a6ad30 >> > [ 46.319363] r8:edf53f80 >> > [ 46.320430] r7:00020000 >> > [ 46.322986] r6:b6de3000 >> > [ 46.324053] r5:ee1c6a00 >> > [ 46.326607] r4:c0248b58 >> > >> > [ 46.330505] [<c039e810>] (full_proxy_read) from [<c021ec98>] (__vfs_read+0x34/0x118) >> > [ 46.338262] r9:edf52000 >> > [ 46.340635] r8:c0107fc4 >> > [ 46.343190] r7:00020000 >> > [ 46.344257] r6:edf53f80 >> > [ 46.346812] r5:c039e810 >> > [ 46.347879] r4:ee1c6a00 >> > [ 46.350447] [<c021ec64>] (__vfs_read) from [<c021fbd0>] (vfs_read+0x8c/0x11c) >> > [ 46.357597] r9:edf52000 >> > [ 46.359969] r8:c0107fc4 >> > [ 46.362524] r7:edf53f80 >> > [ 46.363592] r6:b6de3000 >> > [ 46.366147] r5:ee1c6a00 >> > [ 46.367214] r4:00020000 >> > [ 46.369782] [<c021fb44>] (vfs_read) from [<c0220a4c>] (SyS_read+0x4c/0xa8) >> > [ 46.376672] r8:c0107fc4 >> > [ 46.379045] r7:00020000 >> > [ 46.381600] r6:b6de3000 >> > [ 46.382667] r5:ee1c6a00 >> > [ 46.385222] r4:ee1c6a00 >> > >> > [ 46.387817] [<c0220a00>] (SyS_read) from [<c0107e20>] (ret_fast_syscall+0x0/0x1c) >> > [ 46.395314] r7:00000003 >> > [ 46.397687] r6:b6de3000 >> > [ 46.400243] r5:00020000 >> > [ 46.401310] r4:00020000 >> > >> > Cc: <stable@vger.kernel.org> #v4.1+ >> >> Any idea what commit caused the problem? >> > > This issue has been existed from this driver has written, and the > structure refined later, this patch can be applied after that > (4 years ago), I think v4.1 is the last stable tree it can be > applied. from a quick read, it looks to me like commit e443b333629f82ca0da91a05ca638050943bbedd is the first one where this would be reproducible. That would be v3.5, IIRC. We still have a few longterm kernels before v4.1 which might wanna use this commit. -- balbi [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] usb: chipidea: move the lock initialization to core file 2016-11-15 9:32 ` Felipe Balbi @ 2016-11-15 9:56 ` Peter Chen 2016-11-15 10:05 ` Greg KH 1 sibling, 0 replies; 6+ messages in thread From: Peter Chen @ 2016-11-15 9:56 UTC (permalink / raw) To: Felipe Balbi; +Cc: Greg KH, Peter Chen, linux-usb, #v4 . 1+ On Tue, Nov 15, 2016 at 11:32:02AM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterchen@gmail.com> writes: > > On Tue, Nov 15, 2016 at 07:58:16AM +0100, Greg KH wrote: > >> On Tue, Nov 15, 2016 at 02:02:47PM +0800, Peter Chen wrote: > >> > This can fix below dump when the lock is accessed at host > >> > mode due to it is not initialized. > >> > > >> > [ 46.119638] INFO: trying to register non-static key. > >> > [ 46.124643] the code is fine but needs lockdep annotation. > >> > [ 46.130144] turning off the locking correctness validator. > >> > [ 46.135659] CPU: 0 PID: 690 Comm: cat Not tainted 4.9.0-rc3-00079-g4b75f1d #1210 > >> > [ 46.143075] Hardware name: Freescale i.MX6 SoloX (Device Tree) > >> > [ 46.148923] Backtrace: > >> > [ 46.151448] [<c010c460>] (dump_backtrace) from [<c010c658>] (show_stack+0x18/0x1c) > >> > [ 46.159038] r7:edf52000 > >> > [ 46.161412] r6:60000193 > >> > [ 46.163967] r5:00000000 > >> > [ 46.165035] r4:c0e25c2c > >> > > >> > [ 46.169109] [<c010c640>] (show_stack) from [<c03f58a4>] (dump_stack+0xb4/0xe8) > >> > [ 46.176362] [<c03f57f0>] (dump_stack) from [<c016d690>] (register_lock_class+0x4fc/0x56c) > >> > [ 46.184554] r10:c0e25d24 > >> > [ 46.187014] r9:edf53e70 > >> > [ 46.189569] r8:c1642444 > >> > [ 46.190637] r7:ee9da024 > >> > [ 46.193191] r6:00000000 > >> > [ 46.194258] r5:00000000 > >> > [ 46.196812] r4:00000000 > >> > [ 46.199185] r3:00000001 > >> > > >> > [ 46.203259] [<c016d194>] (register_lock_class) from [<c0171294>] (__lock_acquire+0x80/0x10f0) > >> > [ 46.211797] r10:c0e25d24 > >> > [ 46.214257] r9:edf53e70 > >> > [ 46.216813] r8:ee9da024 > >> > [ 46.217880] r7:c1642444 > >> > [ 46.220435] r6:edcd1800 > >> > [ 46.221502] r5:60000193 > >> > [ 46.224057] r4:00000000 > >> > > >> > [ 46.227953] [<c0171214>] (__lock_acquire) from [<c01726c0>] (lock_acquire+0x74/0x94) > >> > [ 46.235710] r10:00000001 > >> > [ 46.238169] r9:edf53e70 > >> > [ 46.240723] r8:edf53f80 > >> > [ 46.241790] r7:00000001 > >> > [ 46.244344] r6:00000001 > >> > [ 46.245412] r5:60000193 > >> > [ 46.247966] r4:00000000 > >> > > >> > [ 46.251866] [<c017264c>] (lock_acquire) from [<c096c8fc>] (_raw_spin_lock_irqsave+0x40/0x54) > >> > [ 46.260319] r7:ee1c6a00 > >> > [ 46.262691] r6:c062a570 > >> > [ 46.265247] r5:20000113 > >> > [ 46.266314] r4:ee9da014 > >> > > >> > [ 46.270393] [<c096c8bc>] (_raw_spin_lock_irqsave) from [<c062a570>] (ci_port_test_show+0x2c/0x70) > >> > [ 46.279280] r6:eebd2000 > >> > [ 46.281652] r5:ee9da010 > >> > [ 46.284207] r4:ee9da014 > >> > > >> > [ 46.286810] [<c062a544>] (ci_port_test_show) from [<c0248d04>] (seq_read+0x1ac/0x4f8) > >> > [ 46.294655] r9:edf53e70 > >> > [ 46.297028] r8:edf53f80 > >> > [ 46.299583] r7:ee1c6a00 > >> > [ 46.300650] r6:00000001 > >> > [ 46.303205] r5:00000000 > >> > [ 46.304273] r4:eebd2000 > >> > [ 46.306850] [<c0248b58>] (seq_read) from [<c039e864>] (full_proxy_read+0x54/0x6c) > >> > [ 46.314348] r10:00000000 > >> > [ 46.316808] r9:c0a6ad30 > >> > [ 46.319363] r8:edf53f80 > >> > [ 46.320430] r7:00020000 > >> > [ 46.322986] r6:b6de3000 > >> > [ 46.324053] r5:ee1c6a00 > >> > [ 46.326607] r4:c0248b58 > >> > > >> > [ 46.330505] [<c039e810>] (full_proxy_read) from [<c021ec98>] (__vfs_read+0x34/0x118) > >> > [ 46.338262] r9:edf52000 > >> > [ 46.340635] r8:c0107fc4 > >> > [ 46.343190] r7:00020000 > >> > [ 46.344257] r6:edf53f80 > >> > [ 46.346812] r5:c039e810 > >> > [ 46.347879] r4:ee1c6a00 > >> > [ 46.350447] [<c021ec64>] (__vfs_read) from [<c021fbd0>] (vfs_read+0x8c/0x11c) > >> > [ 46.357597] r9:edf52000 > >> > [ 46.359969] r8:c0107fc4 > >> > [ 46.362524] r7:edf53f80 > >> > [ 46.363592] r6:b6de3000 > >> > [ 46.366147] r5:ee1c6a00 > >> > [ 46.367214] r4:00020000 > >> > [ 46.369782] [<c021fb44>] (vfs_read) from [<c0220a4c>] (SyS_read+0x4c/0xa8) > >> > [ 46.376672] r8:c0107fc4 > >> > [ 46.379045] r7:00020000 > >> > [ 46.381600] r6:b6de3000 > >> > [ 46.382667] r5:ee1c6a00 > >> > [ 46.385222] r4:ee1c6a00 > >> > > >> > [ 46.387817] [<c0220a00>] (SyS_read) from [<c0107e20>] (ret_fast_syscall+0x0/0x1c) > >> > [ 46.395314] r7:00000003 > >> > [ 46.397687] r6:b6de3000 > >> > [ 46.400243] r5:00020000 > >> > [ 46.401310] r4:00020000 > >> > > >> > Cc: <stable@vger.kernel.org> #v4.1+ > >> > >> Any idea what commit caused the problem? > >> > > > > This issue has been existed from this driver has written, and the > > structure refined later, this patch can be applied after that > > (4 years ago), I think v4.1 is the last stable tree it can be > > applied. > > from a quick read, it looks to me like commit > e443b333629f82ca0da91a05ca638050943bbedd is the first one where this > would be reproducible. That would be v3.5, IIRC. > > We still have a few longterm kernels before v4.1 which might wanna use > this commit. > Thanks, although the first one should be 26c696c678c4ce180599330999e895cded0f625b, I got the wrong kernel version for it, I will fix it with v3. -- Best Regards, Peter Chen ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] usb: chipidea: move the lock initialization to core file 2016-11-15 9:32 ` Felipe Balbi 2016-11-15 9:56 ` Peter Chen @ 2016-11-15 10:05 ` Greg KH 1 sibling, 0 replies; 6+ messages in thread From: Greg KH @ 2016-11-15 10:05 UTC (permalink / raw) To: Felipe Balbi; +Cc: Peter Chen, Peter Chen, linux-usb, #v4 . 1+ On Tue, Nov 15, 2016 at 11:32:02AM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterchen@gmail.com> writes: > > On Tue, Nov 15, 2016 at 07:58:16AM +0100, Greg KH wrote: > >> On Tue, Nov 15, 2016 at 02:02:47PM +0800, Peter Chen wrote: > >> > This can fix below dump when the lock is accessed at host > >> > mode due to it is not initialized. > >> > > >> > [ 46.119638] INFO: trying to register non-static key. > >> > [ 46.124643] the code is fine but needs lockdep annotation. > >> > [ 46.130144] turning off the locking correctness validator. > >> > [ 46.135659] CPU: 0 PID: 690 Comm: cat Not tainted 4.9.0-rc3-00079-g4b75f1d #1210 > >> > [ 46.143075] Hardware name: Freescale i.MX6 SoloX (Device Tree) > >> > [ 46.148923] Backtrace: > >> > [ 46.151448] [<c010c460>] (dump_backtrace) from [<c010c658>] (show_stack+0x18/0x1c) > >> > [ 46.159038] r7:edf52000 > >> > [ 46.161412] r6:60000193 > >> > [ 46.163967] r5:00000000 > >> > [ 46.165035] r4:c0e25c2c > >> > > >> > [ 46.169109] [<c010c640>] (show_stack) from [<c03f58a4>] (dump_stack+0xb4/0xe8) > >> > [ 46.176362] [<c03f57f0>] (dump_stack) from [<c016d690>] (register_lock_class+0x4fc/0x56c) > >> > [ 46.184554] r10:c0e25d24 > >> > [ 46.187014] r9:edf53e70 > >> > [ 46.189569] r8:c1642444 > >> > [ 46.190637] r7:ee9da024 > >> > [ 46.193191] r6:00000000 > >> > [ 46.194258] r5:00000000 > >> > [ 46.196812] r4:00000000 > >> > [ 46.199185] r3:00000001 > >> > > >> > [ 46.203259] [<c016d194>] (register_lock_class) from [<c0171294>] (__lock_acquire+0x80/0x10f0) > >> > [ 46.211797] r10:c0e25d24 > >> > [ 46.214257] r9:edf53e70 > >> > [ 46.216813] r8:ee9da024 > >> > [ 46.217880] r7:c1642444 > >> > [ 46.220435] r6:edcd1800 > >> > [ 46.221502] r5:60000193 > >> > [ 46.224057] r4:00000000 > >> > > >> > [ 46.227953] [<c0171214>] (__lock_acquire) from [<c01726c0>] (lock_acquire+0x74/0x94) > >> > [ 46.235710] r10:00000001 > >> > [ 46.238169] r9:edf53e70 > >> > [ 46.240723] r8:edf53f80 > >> > [ 46.241790] r7:00000001 > >> > [ 46.244344] r6:00000001 > >> > [ 46.245412] r5:60000193 > >> > [ 46.247966] r4:00000000 > >> > > >> > [ 46.251866] [<c017264c>] (lock_acquire) from [<c096c8fc>] (_raw_spin_lock_irqsave+0x40/0x54) > >> > [ 46.260319] r7:ee1c6a00 > >> > [ 46.262691] r6:c062a570 > >> > [ 46.265247] r5:20000113 > >> > [ 46.266314] r4:ee9da014 > >> > > >> > [ 46.270393] [<c096c8bc>] (_raw_spin_lock_irqsave) from [<c062a570>] (ci_port_test_show+0x2c/0x70) > >> > [ 46.279280] r6:eebd2000 > >> > [ 46.281652] r5:ee9da010 > >> > [ 46.284207] r4:ee9da014 > >> > > >> > [ 46.286810] [<c062a544>] (ci_port_test_show) from [<c0248d04>] (seq_read+0x1ac/0x4f8) > >> > [ 46.294655] r9:edf53e70 > >> > [ 46.297028] r8:edf53f80 > >> > [ 46.299583] r7:ee1c6a00 > >> > [ 46.300650] r6:00000001 > >> > [ 46.303205] r5:00000000 > >> > [ 46.304273] r4:eebd2000 > >> > [ 46.306850] [<c0248b58>] (seq_read) from [<c039e864>] (full_proxy_read+0x54/0x6c) > >> > [ 46.314348] r10:00000000 > >> > [ 46.316808] r9:c0a6ad30 > >> > [ 46.319363] r8:edf53f80 > >> > [ 46.320430] r7:00020000 > >> > [ 46.322986] r6:b6de3000 > >> > [ 46.324053] r5:ee1c6a00 > >> > [ 46.326607] r4:c0248b58 > >> > > >> > [ 46.330505] [<c039e810>] (full_proxy_read) from [<c021ec98>] (__vfs_read+0x34/0x118) > >> > [ 46.338262] r9:edf52000 > >> > [ 46.340635] r8:c0107fc4 > >> > [ 46.343190] r7:00020000 > >> > [ 46.344257] r6:edf53f80 > >> > [ 46.346812] r5:c039e810 > >> > [ 46.347879] r4:ee1c6a00 > >> > [ 46.350447] [<c021ec64>] (__vfs_read) from [<c021fbd0>] (vfs_read+0x8c/0x11c) > >> > [ 46.357597] r9:edf52000 > >> > [ 46.359969] r8:c0107fc4 > >> > [ 46.362524] r7:edf53f80 > >> > [ 46.363592] r6:b6de3000 > >> > [ 46.366147] r5:ee1c6a00 > >> > [ 46.367214] r4:00020000 > >> > [ 46.369782] [<c021fb44>] (vfs_read) from [<c0220a4c>] (SyS_read+0x4c/0xa8) > >> > [ 46.376672] r8:c0107fc4 > >> > [ 46.379045] r7:00020000 > >> > [ 46.381600] r6:b6de3000 > >> > [ 46.382667] r5:ee1c6a00 > >> > [ 46.385222] r4:ee1c6a00 > >> > > >> > [ 46.387817] [<c0220a00>] (SyS_read) from [<c0107e20>] (ret_fast_syscall+0x0/0x1c) > >> > [ 46.395314] r7:00000003 > >> > [ 46.397687] r6:b6de3000 > >> > [ 46.400243] r5:00020000 > >> > [ 46.401310] r4:00020000 > >> > > >> > Cc: <stable@vger.kernel.org> #v4.1+ > >> > >> Any idea what commit caused the problem? > >> > > > > This issue has been existed from this driver has written, and the > > structure refined later, this patch can be applied after that > > (4 years ago), I think v4.1 is the last stable tree it can be > > applied. > > from a quick read, it looks to me like commit > e443b333629f82ca0da91a05ca638050943bbedd is the first one where this > would be reproducible. That would be v3.5, IIRC. > > We still have a few longterm kernels before v4.1 which might wanna use > this commit. Thanks for digging this up. Peter, please redo this patch with the Fixes: tag in it. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-15 10:05 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-11-15 6:02 [PATCH v2 1/1] usb: chipidea: move the lock initialization to core file Peter Chen 2016-11-15 6:58 ` Greg KH 2016-11-15 7:15 ` Peter Chen 2016-11-15 9:32 ` Felipe Balbi 2016-11-15 9:56 ` Peter Chen 2016-11-15 10:05 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox