Patch "btrfs: remove duplicate const specifier" has been added to the 4.4-stable tree

Patch "btrfs: remove duplicate const specifier" has been added to the 4.4-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    btrfs: remove duplicate const specifier

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     btrfs-remove-duplicate-const-specifier.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From fb75d857a31d600cc0c37b8c7d914014f7fa3f9a Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.king@canonical.com>
Date: Tue, 19 Jan 2016 00:05:28 +0000
Subject: btrfs: remove duplicate const specifier

From: Colin Ian King <colin.king@canonical.com>

commit fb75d857a31d600cc0c37b8c7d914014f7fa3f9a upstream.

duplicate const is redundant so remove it

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/btrfs/volumes.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -108,7 +108,7 @@ const struct btrfs_raid_attr btrfs_raid_
 	},
 };
 
-const u64 const btrfs_raid_group[BTRFS_NR_RAID_TYPES] = {
+const u64 btrfs_raid_group[BTRFS_NR_RAID_TYPES] = {
 	[BTRFS_RAID_RAID10] = BTRFS_BLOCK_GROUP_RAID10,
 	[BTRFS_RAID_RAID1]  = BTRFS_BLOCK_GROUP_RAID1,
 	[BTRFS_RAID_DUP]    = BTRFS_BLOCK_GROUP_DUP,


Patches currently in stable-queue which might be from colin.king@canonical.com are

queue-4.4/btrfs-remove-duplicate-const-specifier.patch

Re: Patch "btrfs: remove duplicate const specifier" has been added to the 4.4-stable tree

[David Sterba]

On Wed, Aug 30, 2017 at 05:29:36PM +0200, gregkh@linuxfoundation.org wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     btrfs: remove duplicate const specifier
> 
> to the 4.4-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      btrfs-remove-duplicate-const-specifier.patch
> and it can be found in the queue-4.4 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.

This patch IMO does not belong to stable, it's just a cleanup and does
not fix anything that's worth the time of anybody involved in stable trees.

> From fb75d857a31d600cc0c37b8c7d914014f7fa3f9a Mon Sep 17 00:00:00 2001
> From: Colin Ian King <colin.king@canonical.com>
> Date: Tue, 19 Jan 2016 00:05:28 +0000
> Subject: btrfs: remove duplicate const specifier
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> commit fb75d857a31d600cc0c37b8c7d914014f7fa3f9a upstream.
> 
> duplicate const is redundant so remove it
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: David Sterba <dsterba@suse.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> ---
>  fs/btrfs/volumes.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -108,7 +108,7 @@ const struct btrfs_raid_attr btrfs_raid_
>  	},
>  };
>  
> -const u64 const btrfs_raid_group[BTRFS_NR_RAID_TYPES] = {
> +const u64 btrfs_raid_group[BTRFS_NR_RAID_TYPES] = {
>  	[BTRFS_RAID_RAID10] = BTRFS_BLOCK_GROUP_RAID10,
>  	[BTRFS_RAID_RAID1]  = BTRFS_BLOCK_GROUP_RAID1,
>  	[BTRFS_RAID_DUP]    = BTRFS_BLOCK_GROUP_DUP,
> 
> 
> Patches currently in stable-queue which might be from colin.king@canonical.com are
> 
> queue-4.4/btrfs-remove-duplicate-const-specifier.patch
> 

Re: Patch "btrfs: remove duplicate const specifier" has been added to the 4.4-stable tree

[Greg KH]

On Wed, Aug 30, 2017 at 06:50:07PM +0200, David Sterba wrote:
> On Wed, Aug 30, 2017 at 05:29:36PM +0200, gregkh@linuxfoundation.org wrote:
> > 
> > This is a note to let you know that I've just added the patch titled
> > 
> >     btrfs: remove duplicate const specifier
> > 
> > to the 4.4-stable tree which can be found at:
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > The filename of the patch is:
> >      btrfs-remove-duplicate-const-specifier.patch
> > and it can be found in the queue-4.4 subdirectory.
> > 
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> 
> This patch IMO does not belong to stable, it's just a cleanup and does
> not fix anything that's worth the time of anybody involved in stable trees.

On the contrary, it fixes a build warning in the tree, and having lots
of warnings hides real problems.  The tree used to build "clean" with
gcc6, but now that my build systems are running gcc7, stuff like this
needs to get cleaned up again.

So this is a needed fix.

thanks,

greg k-h