Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
	Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
	<stable@vger.kernel.org>, <patches@opensource.cirrus.com>,
	<alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: wm_adsp: Fix validation of firmware and coeff lengths
Date: Fri, 8 Dec 2017 09:36:19 +0000	[thread overview]
Message-ID: <20171208093619.jtnuvjfmane4ezas@localhost.localdomain> (raw)
In-Reply-To: <20171207211928.btwtwlfci6f4hku2@xylophone.i.decadent.org.uk>

On Thu, Dec 07, 2017 at 09:19:29PM +0000, Ben Hutchings wrote:
> The checks for whether another region/block header could be present
> are subtracting the size from the current offset.  Obviously we should
> instead subtract the offset from the size.
> 
> The checks for whether the region/block data fit in the file are
> adding the data size to the current offset and header size, without
> checking for integer overflow.  Rearrange these so that overflow is
> impossible.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Tested-by: Charles Keepax <ckeepax@opensource.cirrus.com>

But you would probably be best to resend and include Mark Brown
in the To: field. He applies the Wolfson patches directly to his
tree and he might miss it since it just went to the list.

Thanks,
Charles

  reply	other threads:[~2017-12-08  9:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 21:19 [PATCH] ASoC: wm_adsp: Fix validation of firmware and coeff lengths Ben Hutchings
2017-12-08  9:36 ` Charles Keepax [this message]
2017-12-08 17:18 ` Applied "ASoC: wm_adsp: Fix validation of firmware and coeff lengths" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171208093619.jtnuvjfmane4ezas@localhost.localdomain \
    --to=ckeepax@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=ben.hutchings@codethink.co.uk \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=patches@opensource.cirrus.com \
    --cc=rf@opensource.wolfsonmicro.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox