Linux kernel -stable discussions
 help / color / mirror / Atom feed
* Re: [PATCH] ovl: fix overlay: warning prefix
       [not found] <1511375254-15206-1-git-send-email-amir73il@gmail.com>
@ 2017-12-18 12:19 ` Amir Goldstein
  2017-12-18 12:35   ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Amir Goldstein @ 2017-12-18 12:19 UTC (permalink / raw)
  To: Greg KH; +Cc: overlayfs, Miklos Szeredi, stable

On Wed, Nov 22, 2017 at 8:27 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> Conform two stray warning messages to the standard overlayfs: prefix.
>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---

Greg,

Upstream commit ("da2e6b7eeda8 ovl: fix overlay: warning prefix")
was not marked for stable, because it is not a bug fix per-se.
Nevertheless, it may be useful to apply it to stable kernels to keep
overlayfs bug reports/analysis consistent.

The first hunk fixes (#v4.10):
a6c606551141 ovl: redirect on rename-dir

The second hunk fixes (#v4.14):
b5efccbe0a12 ovl: constant d_ino across copy up

For your consideration.
If you wish, I can send a patch for v4.10 with just the first hunk.

Thanks,
Amir.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ovl: fix overlay: warning prefix
  2017-12-18 12:19 ` [PATCH] ovl: fix overlay: warning prefix Amir Goldstein
@ 2017-12-18 12:35   ` Greg KH
  2017-12-18 12:43     ` Amir Goldstein
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2017-12-18 12:35 UTC (permalink / raw)
  To: Amir Goldstein; +Cc: overlayfs, Miklos Szeredi, stable

On Mon, Dec 18, 2017 at 02:19:52PM +0200, Amir Goldstein wrote:
> On Wed, Nov 22, 2017 at 8:27 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> > Conform two stray warning messages to the standard overlayfs: prefix.
> >
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> > ---
> 
> Greg,
> 
> Upstream commit ("da2e6b7eeda8 ovl: fix overlay: warning prefix")
> was not marked for stable, because it is not a bug fix per-se.
> Nevertheless, it may be useful to apply it to stable kernels to keep
> overlayfs bug reports/analysis consistent.
> 
> The first hunk fixes (#v4.10):
> a6c606551141 ovl: redirect on rename-dir
> 
> The second hunk fixes (#v4.14):
> b5efccbe0a12 ovl: constant d_ino across copy up
> 
> For your consideration.
> If you wish, I can send a patch for v4.10 with just the first hunk.


4.10 is long end-of-life, so I don't think that matters :)

As for 4.14, this is just an error message, I don't think it's that
serious of a fix for a stable kernel, do you?  It's _this_ close to just
being a spelling fix.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ovl: fix overlay: warning prefix
  2017-12-18 12:35   ` Greg KH
@ 2017-12-18 12:43     ` Amir Goldstein
  0 siblings, 0 replies; 3+ messages in thread
From: Amir Goldstein @ 2017-12-18 12:43 UTC (permalink / raw)
  To: Greg KH; +Cc: overlayfs, Miklos Szeredi, stable

On Mon, Dec 18, 2017 at 2:35 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Dec 18, 2017 at 02:19:52PM +0200, Amir Goldstein wrote:
>> On Wed, Nov 22, 2017 at 8:27 PM, Amir Goldstein <amir73il@gmail.com> wrote:
>> > Conform two stray warning messages to the standard overlayfs: prefix.
>> >
>> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
>> > ---
>>
>> Greg,
>>
>> Upstream commit ("da2e6b7eeda8 ovl: fix overlay: warning prefix")
>> was not marked for stable, because it is not a bug fix per-se.
>> Nevertheless, it may be useful to apply it to stable kernels to keep
>> overlayfs bug reports/analysis consistent.
>>
>> The first hunk fixes (#v4.10):
>> a6c606551141 ovl: redirect on rename-dir
>>
>> The second hunk fixes (#v4.14):
>> b5efccbe0a12 ovl: constant d_ino across copy up
>>
>> For your consideration.
>> If you wish, I can send a patch for v4.10 with just the first hunk.
>
>
> 4.10 is long end-of-life, so I don't think that matters :)

Yeh, I thought 4.13 was still around, but it's not...

>
> As for 4.14, this is just an error message, I don't think it's that
> serious of a fix for a stable kernel, do you?  It's _this_ close to just
> being a spelling fix.
>

Not serious at all.
It's just that collecting overlayfs output from kmsg on bug reports
is one notch easier to request.

I can certainly live without it being in a stable.

Thanks,
Amir.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-12-18 12:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1511375254-15206-1-git-send-email-amir73il@gmail.com>
2017-12-18 12:19 ` [PATCH] ovl: fix overlay: warning prefix Amir Goldstein
2017-12-18 12:35   ` Greg KH
2017-12-18 12:43     ` Amir Goldstein

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox