[PATCH] serial: core: mark port as initialized in autoconfig

[PATCH] serial: core: mark port as initialized in autoconfig

[Sebastian Andrzej Siewior]

This is a followup on 44117a1d1732 ("serial: core: mark port as
initialized after successful IRQ change").
Nikola has been using autoconfig via setserial and reported a crash
similar to what I fixed in the earlier mentioned commit. Here I do the
same fixup for the autoconfig. I wasn't sure that this is the right
approach. Nikola confirmed that it fixes his crash.

Fixes: b3b576461864 ("tty: serial_core: convert uart_open to use tty_port_open")
Link: http://lkml.kernel.org/r/20180131072000.GD1853@localhost.localdomain
Reported-by: Nikola Ciprich <nikola.ciprich@linuxbox.cz>
Tested-by: Nikola Ciprich <nikola.ciprich@linuxbox.cz>
Cc: Johan Hovold <johan@kernel.org>
Cc: Nikola Ciprich <nikola.ciprich@linuxbox.cz>
Cc: <stable@vger.kernel.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/tty/serial/serial_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index c8dde56b532b..35b9201db3b4 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -1144,6 +1144,8 @@ static int uart_do_autoconfig(struct tty_struct *tty,struct uart_state *state)
 		uport->ops->config_port(uport, flags);
 
 		ret = uart_startup(tty, state, 1);
+		if (ret == 0)
+			tty_port_set_initialized(port, true);
 		if (ret > 0)
 			ret = 0;
 	}
-- 
2.15.1

Re: [PATCH] serial: core: mark port as initialized in autoconfig

[Nikola Ciprich]

[-- Attachment #1: Type: text/plain, Size: 55 bytes --]

Tested-by: Nikola Ciprich <nikola.ciprich@linuxbox.cz>

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] serial: core: mark port as initialized in autoconfig

[Johan Hovold]

On Sat, Feb 03, 2018 at 12:27:23PM +0100, Sebastian Andrzej Siewior wrote:
> This is a followup on 44117a1d1732 ("serial: core: mark port as
> initialized after successful IRQ change").
> Nikola has been using autoconfig via setserial and reported a crash
> similar to what I fixed in the earlier mentioned commit. Here I do the
> same fixup for the autoconfig. I wasn't sure that this is the right
> approach. Nikola confirmed that it fixes his crash.
> 
> Fixes: b3b576461864 ("tty: serial_core: convert uart_open to use tty_port_open")
> Link: http://lkml.kernel.org/r/20180131072000.GD1853@localhost.localdomain
> Reported-by: Nikola Ciprich <nikola.ciprich@linuxbox.cz>
> Tested-by: Nikola Ciprich <nikola.ciprich@linuxbox.cz>
> Cc: Johan Hovold <johan@kernel.org>
> Cc: Nikola Ciprich <nikola.ciprich@linuxbox.cz>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Acked-by: Johan Hovold <johan@kernel.org>