* [PATCH v3] platform/x86: dell-laptop: fix kbd_get_state's request value
@ 2018-02-13 20:43 Laszlo Toth
2018-02-13 21:26 ` Pali Rohár
0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Toth @ 2018-02-13 20:43 UTC (permalink / raw)
To: Matthew Garrett, Pali Rohár, Darren Hart, Andy Shevchenko,
Mario Limonciello, platform-driver-x86
Cc: stable
Commit 9862b43624a5 ("platform/x86: dell-laptop: Allocate buffer on heap
rather than globally")
broke one request, changed it back to the original value.
Tested on a Dell E6540, backlight came back.
Fixes: 9862b43624a5 ("platform/x86: dell-laptop: Allocate buffer on heap rather than globally")
Signed-off-by: Laszlo Toth <laszlth@gmail.com>
---
Changes in v2:
- split the fix and the function merge part
Changes in v3:
- added fixes tag
drivers/platform/x86/dell-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index 2a68f59..a37cff9 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -1279,7 +1279,7 @@ static int kbd_get_state(struct kbd_state *state)
struct calling_interface_buffer buffer;
int ret;
- dell_fill_request(&buffer, 0, 0, 0, 0);
+ dell_fill_request(&buffer, 0x1, 0, 0, 0);
ret = dell_send_request(&buffer,
CLASS_KBD_BACKLIGHT, SELECT_KBD_BACKLIGHT);
if (ret)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3] platform/x86: dell-laptop: fix kbd_get_state's request value
2018-02-13 20:43 [PATCH v3] platform/x86: dell-laptop: fix kbd_get_state's request value Laszlo Toth
@ 2018-02-13 21:26 ` Pali Rohár
2018-02-14 19:44 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Pali Rohár @ 2018-02-13 21:26 UTC (permalink / raw)
To: Laszlo Toth
Cc: Matthew Garrett, Darren Hart, Andy Shevchenko, Mario Limonciello,
platform-driver-x86, stable
[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]
On Tuesday 13 February 2018 21:43:43 Laszlo Toth wrote:
> Commit 9862b43624a5 ("platform/x86: dell-laptop: Allocate buffer on heap
> rather than globally")
> broke one request, changed it back to the original value.
>
> Tested on a Dell E6540, backlight came back.
>
> Fixes: 9862b43624a5 ("platform/x86: dell-laptop: Allocate buffer on heap rather than globally")
> Signed-off-by: Laszlo Toth <laszlth@gmail.com>
> ---
> Changes in v2:
> - split the fix and the function merge part
> Changes in v3:
> - added fixes tag
>
> drivers/platform/x86/dell-laptop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index 2a68f59..a37cff9 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -1279,7 +1279,7 @@ static int kbd_get_state(struct kbd_state *state)
> struct calling_interface_buffer buffer;
> int ret;
>
> - dell_fill_request(&buffer, 0, 0, 0, 0);
> + dell_fill_request(&buffer, 0x1, 0, 0, 0);
> ret = dell_send_request(&buffer,
> CLASS_KBD_BACKLIGHT, SELECT_KBD_BACKLIGHT);
> if (ret)
Looks better!
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] platform/x86: dell-laptop: fix kbd_get_state's request value
2018-02-13 21:26 ` Pali Rohár
@ 2018-02-14 19:44 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2018-02-14 19:44 UTC (permalink / raw)
To: Pali Rohár
Cc: Laszlo Toth, Matthew Garrett, Darren Hart, Andy Shevchenko,
Mario Limonciello, Platform Driver, Stable
On Tue, Feb 13, 2018 at 11:26 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Tuesday 13 February 2018 21:43:43 Laszlo Toth wrote:
>> Commit 9862b43624a5 ("platform/x86: dell-laptop: Allocate buffer on heap
>> rather than globally")
>> broke one request, changed it back to the original value.
>>
>> Tested on a Dell E6540, backlight came back.
>>
Pushed to my review and testing queue, thanks!
>> Fixes: 9862b43624a5 ("platform/x86: dell-laptop: Allocate buffer on heap rather than globally")
>> Signed-off-by: Laszlo Toth <laszlth@gmail.com>
>> ---
>> Changes in v2:
>> - split the fix and the function merge part
>> Changes in v3:
>> - added fixes tag
>>
>> drivers/platform/x86/dell-laptop.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
>> index 2a68f59..a37cff9 100644
>> --- a/drivers/platform/x86/dell-laptop.c
>> +++ b/drivers/platform/x86/dell-laptop.c
>> @@ -1279,7 +1279,7 @@ static int kbd_get_state(struct kbd_state *state)
>> struct calling_interface_buffer buffer;
>> int ret;
>>
>> - dell_fill_request(&buffer, 0, 0, 0, 0);
>> + dell_fill_request(&buffer, 0x1, 0, 0, 0);
>> ret = dell_send_request(&buffer,
>> CLASS_KBD_BACKLIGHT, SELECT_KBD_BACKLIGHT);
>> if (ret)
>
> Looks better!
>
> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
>
> --
> Pali Rohár
> pali.rohar@gmail.com
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-14 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-13 20:43 [PATCH v3] platform/x86: dell-laptop: fix kbd_get_state's request value Laszlo Toth
2018-02-13 21:26 ` Pali Rohár
2018-02-14 19:44 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox