From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>, "hch@lst.de" <hch@lst.de>,
"tj@kernel.org" <tj@kernel.org>,
"israelr@mellanox.com" <israelr@mellanox.com>,
"maxg@mellanox.com" <maxg@mellanox.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"jianchao.w.wang@oracle.com" <jianchao.w.wang@oracle.com>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH V3] blk-mq: fix race between complete and BLK_EH_RESET_TIMER
Date: Sun, 15 Apr 2018 23:15:39 +0800 [thread overview]
Message-ID: <20180415151537.GA2406@ming.t460p> (raw)
In-Reply-To: <60846d0eea47181049fe77a0b303d7e04348b951.camel@wdc.com>
On Sat, Apr 14, 2018 at 03:22:07PM +0000, Bart Van Assche wrote:
> On Fri, 2018-04-13 at 21:06 -0600, Jens Axboe wrote:
> > I like this approach since it keeps the cost outside of the fast
> > path. And it's fine to reuse the queue lock for this, instead of
> > adding a special lock for something we consider a rare occurrence.
> >
> > From a quick look this looks sane, but I'll take a closer look
> > tomrrow and add some testing too.
Jens, please hold on, I will post out V4 soon, which will improve V3 a bit.
>
> Shouldn't we know the root cause of the "RIP: scsi_times_out+0x17" crash reported in
> https://bugzilla.kernel.org/show_bug.cgi?id=199077 before we decide how to proceed?
I will ask Martin to test the V4 once it is posted out.
Thanks,
Ming
prev parent reply other threads:[~2018-04-15 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 11:59 [PATCH V3] blk-mq: fix race between complete and BLK_EH_RESET_TIMER Ming Lei
2018-04-14 3:06 ` Jens Axboe
2018-04-14 15:22 ` Bart Van Assche
2018-04-15 15:15 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180415151537.GA2406@ming.t460p \
--to=ming.lei@redhat.com \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox