From: Greg KH <greg@kroah.com>
To: Yongqin Liu <yongqin.liu@linaro.org>
Cc: stable@vger.kernel.org, Tom Gall <tom.gall@linaro.org>,
Alistair Strachan <alistair.strachan@linaro.org>,
Greg Kroah-Hartman <gregkh@google.com>,
"avid S. Miller" <davem@davemloft.net>,
John Stultz <john.stultz@linaro.org>,
Thomas Egerer <hakke_007@gmx.de>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: Please help to apply commit 32b6170ca59c("ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV")into the 4.4 stable kernel
Date: Wed, 8 Aug 2018 10:44:13 +0200 [thread overview]
Message-ID: <20180808084413.GB24734@kroah.com> (raw)
In-Reply-To: <CAMSo37VoCpVNJO14AaumTp_zLQp3WAHe54UEt4JV5hBVJ3SctA@mail.gmail.com>
On Wed, Aug 08, 2018 at 04:19:10PM +0800, Yongqin Liu wrote:
> Hi, All
> Sorry, I am following the instructions in
> Documentation/networking/netdev-FAQ.txt to send out this mail,
> if I was wrong or there are more things I need to do, please let me know.
>
> After investigated on some failures of the android VtsKernelNetTest module test,
> I found that without the change of "ipv4+ipv6: Make INET*_ESP select
> CRYPTO_ECHAINIV",
> the config of CRYPTO_ECHAINIV will be generated as m by default in the
> .config file,
> which needs more module loading process to be done.
> But with the 4.9 and 4.14 kernels which have the change,
> CRYPTO_ECHAINIV will be generated as y by default in the .config file.
>
> We could set config of CRYPTO_ECHAINIV to y explicitly to generated
> the correct .config file,
That would be the easiest solution here, right? Why can you not do
that?
> but having the change of "ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV"
> cherry picked into the 4.4 stable kernel looks more like the right solution.
>
> The commit id for that change is 32b6170ca59ccf07d0e394561e54b2cd9726038c,
> it's already in 4.9 and 4.14 kernels, like here:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/net/?h=linux-4.9.y&id=32b6170ca59ccf07d0e394561e54b2cd9726038c
Yes, because it showed up in 4.5 :)
Shouldn't your device configurations for 4.4 already be long done? You
had better not be working on new systems with a 4.4 kernel, otherwise
you are in big trouble for many other reasons. So your configuration
should already be finished so I fail to see how backporting this is
really going to solve anyone's problems.
thanks,
greg k-h
next prev parent reply other threads:[~2018-08-08 11:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 8:19 Please help to apply commit 32b6170ca59c("ipv4+ipv6: Make INET*_ESP select CRYPTO_ECHAINIV")into the 4.4 stable kernel Yongqin Liu
2018-08-08 8:44 ` Greg KH [this message]
2018-08-08 10:15 ` Yongqin Liu
2018-08-10 14:11 ` Greg KH
2018-08-10 14:56 ` Yongqin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180808084413.GB24734@kroah.com \
--to=greg@kroah.com \
--cc=alistair.strachan@linaro.org \
--cc=davem@davemloft.net \
--cc=gregkh@google.com \
--cc=hakke_007@gmx.de \
--cc=herbert@gondor.apana.org.au \
--cc=john.stultz@linaro.org \
--cc=stable@vger.kernel.org \
--cc=tom.gall@linaro.org \
--cc=yongqin.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox