From: Sasha Levin <sashal@kernel.org>
To: "J. Bruce Fields" <bfields@redhat.com>
Cc: gregkh@linuxfoundation.org, yuehaibing@huawei.com,
stable@vger.kernel.org
Subject: Re: WTF: patch "[PATCH] SUNRPC: drop pointless static qualifier in" was seriously submitted to be applied to the 4.19-stable tree?
Date: Fri, 23 Nov 2018 14:15:59 -0500 [thread overview]
Message-ID: <20181123191559.GE1917@sasha-vm> (raw)
In-Reply-To: <20181119170327.GA3814@parsley.fieldses.org>
On Mon, Nov 19, 2018 at 12:03:28PM -0500, J. Bruce Fields wrote:
>On Mon, Nov 19, 2018 at 01:45:19PM +0100, gregkh@linuxfoundation.org wrote:
>> The patch below was submitted to be applied to the 4.19-stable tree.
>>
>> I fail to see how this patch meets the stable kernel rules as found at
>> Documentation/process/stable-kernel-rules.rst.
>
>I should have rewritten that changelog, Yue Hainbing's makes it just
>sound like cleanup.
>
>That variable should definitely be private to each task, the sharing
>could cause real bugs.
>
>Admittedly, I don't have actual bug reports, so you could argue this
>falls under the 'No "theoretical race condition"' rule, but the
>potential consequences are pretty bad and the fix very simple, so I
>still think it's a good stable candidate.
Thanks for the explanation, I've queued it for all stable branches.
--
Thanks,
Sasha
prev parent reply other threads:[~2018-11-24 6:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 12:45 WTF: patch "[PATCH] SUNRPC: drop pointless static qualifier in" was seriously submitted to be applied to the 4.19-stable tree? gregkh
2018-11-19 17:03 ` J. Bruce Fields
2018-11-23 19:15 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123191559.GE1917@sasha-vm \
--to=sashal@kernel.org \
--cc=bfields@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox