From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: stable@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Will Deacon <will.deacon@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Daniel Wagner <daniel.wagner@siemens.com>,
bigeasy@linutronix.de, Waiman Long <longman@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
boqun.feng@gmail.com, linux-arm-kernel@lists.infradead.org,
paulmck@linux.vnet.ibm.com, Ingo Molnar <mingo@kernel.org>
Subject: [PATCH STABLE v4.9 06/10] locking/qspinlock: Remove duplicate clear_pending() function from PV code
Date: Tue, 18 Dec 2018 23:10:45 +0100 [thread overview]
Message-ID: <20181218221049.6816-7-bigeasy@linutronix.de> (raw)
In-Reply-To: <20181218221049.6816-1-bigeasy@linutronix.de>
From: Will Deacon <will.deacon@arm.com>
commit 3bea9adc96842b8a7345c7fb202c16ae9c8d5b25 upstream.
The native clear_pending() function is identical to the PV version, so the
latter can simply be removed.
This fixes the build for systems with >= 16K CPUs using the PV lock implementation.
Reported-by: Waiman Long <longman@redhat.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: boqun.feng@gmail.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: paulmck@linux.vnet.ibm.com
Link: http://lkml.kernel.org/r/20180427101619.GB21705@arm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
kernel/locking/qspinlock_paravirt.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/locking/qspinlock_paravirt.h b/kernel/locking/qspinlock_paravirt.h
index 9c07c72fb10e9..af2a24d484aab 100644
--- a/kernel/locking/qspinlock_paravirt.h
+++ b/kernel/locking/qspinlock_paravirt.h
@@ -105,11 +105,6 @@ static __always_inline void set_pending(struct qspinlock *lock)
atomic_or(_Q_PENDING_VAL, &lock->val);
}
-static __always_inline void clear_pending(struct qspinlock *lock)
-{
- atomic_andnot(_Q_PENDING_VAL, &lock->val);
-}
-
static __always_inline int trylock_clear_pending(struct qspinlock *lock)
{
int val = atomic_read(&lock->val);
--
2.20.1
next prev parent reply other threads:[~2018-12-18 22:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 22:10 [PATCH STABLE v4.9 00/10] Backport for "cache line starvation on x86 Sebastian Andrzej Siewior
2018-12-18 22:10 ` [PATCH STABLE v4.9 01/10] locking: Remove smp_read_barrier_depends() from queued_spin_lock_slowpath() Sebastian Andrzej Siewior
2018-12-18 22:10 ` [PATCH STABLE v4.9 02/10] locking/qspinlock: Ensure node is initialised before updating prev->next Sebastian Andrzej Siewior
2018-12-18 22:10 ` [PATCH STABLE v4.9 03/10] locking/qspinlock: Bound spinning on pending->locked transition in slowpath Sebastian Andrzej Siewior
2018-12-18 22:10 ` [PATCH STABLE v4.9 04/10] locking/qspinlock: Merge 'struct __qspinlock' into 'struct qspinlock' Sebastian Andrzej Siewior
2018-12-18 22:10 ` [PATCH STABLE v4.9 05/10] locking/qspinlock: Remove unbounded cmpxchg() loop from locking slowpath Sebastian Andrzej Siewior
2018-12-18 22:10 ` Sebastian Andrzej Siewior [this message]
2018-12-18 22:10 ` [PATCH STABLE v4.9 07/10] locking/qspinlock: Kill cmpxchg() loop when claiming lock from head of queue Sebastian Andrzej Siewior
2018-12-18 22:10 ` [PATCH STABLE v4.9 08/10] locking/qspinlock: Re-order code Sebastian Andrzej Siewior
2018-12-18 22:10 ` [PATCH STABLE v4.9 09/10] locking/qspinlock/x86: Increase _Q_PENDING_LOOPS upper bound Sebastian Andrzej Siewior
2018-12-18 22:10 ` [PATCH STABLE v4.9 10/10] locking/qspinlock, x86: Provide liveness guarantee Sebastian Andrzej Siewior
2018-12-18 22:35 ` [PATCH STABLE v4.9 00/10] Backport for "cache line starvation on x86 Sasha Levin
-- strict thread matches above, loose matches on Subject: below --
2018-12-13 14:09 Sebastian Andrzej Siewior
2018-12-13 14:09 ` [PATCH STABLE v4.9 06/10] locking/qspinlock: Remove duplicate clear_pending() function from PV code Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218221049.6816-7-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=daniel.wagner@siemens.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox